Bugzilla Bug 127404

Fails to compile with gcc-4.1.0, works with gcc-3.4.5

Error:
if x86_64-pc-linux-gnu-g++ -DHAVE_CONFIG_H -I. -I. -I../../../simgear
-I../../..  -I/usr/X11R6/include  -pipe -O2 -march=k8 -D_REENTRANT -MT
placement.o -MD -MP -MF ".deps/placement.Tpo" -c -o placement.o placement.cxx;
\
then mv -f ".deps/placement.Tpo" ".deps/placement.Po"; else rm -f
".deps/placement.Tpo"; exit 1; fi
placement.hxx:49: error: extra qualification 'SGModelPlacement::' on member
'init'
make[4]: *** [placement.o] Error 1
make[4]: Leaving directory
`/var/tmp/portage/simgear-0.3.9/work/SimGear-0.3.9/simgear/scene/model'
make[3]: *** [all-recursive] Error 1
make[3]: Leaving directory
`/var/tmp/portage/simgear-0.3.9/work/SimGear-0.3.9/simgear/scene'
make[2]: *** [all-recursive] Error 1
make[2]: Leaving directory
`/var/tmp/portage/simgear-0.3.9/work/SimGear-0.3.9/simgear'
make[1]: *** [all] Error 2
make[1]: Leaving directory
`/var/tmp/portage/simgear-0.3.9/work/SimGear-0.3.9/simgear'
make: *** [all-recursive] Error 1

emerge --info:
Portage 2.1_pre6-r5 (!/usr/portage/profiles/default-linux/amd64/2006.0,
gcc-4.1.0, glibc-2.4-r1, 2.6.16-mm1 x86_64)
=================================================================
System uname: 2.6.16-mm1 x86_64 AMD Athlon(tm) 64 X2 Dual Core Processor 4200+
Gentoo Base System version 1.12.0_pre16
distcc[25909] (dcc_mkdir) ERROR: mkdir /var/tmp/portage/.distcc//state failed:
No such file or directory [disabled]
dev-lang/python:     2.3.5, 2.4.2-r1
sys-apps/sandbox:    1.2.17
sys-devel/autoconf:  2.13, 2.59-r7
sys-devel/automake:  1.4_p6, 1.5, 1.6.3, 1.7.9-r1, 1.8.5-r3, 1.9.6-r1
sys-devel/binutils:  2.16.1-r2
sys-devel/libtool:   1.5.22
virtual/os-headers:  2.6.11-r3
ACCEPT_KEYWORDS="amd64 ~amd64"
AUTOCLEAN="yes"
CBUILD="x86_64-pc-linux-gnu"
CFLAGS="-pipe -O2 -march=k8"
CHOST="x86_64-pc-linux-gnu"
CONFIG_PROTECT="/etc /usr/NX/etc /usr/NX/home /usr/kde/2/share/config
/usr/kde/3.5/env /usr/kde/3.5/share/config /usr/kde/3.5/shutdown
/usr/kde/3/share/config /usr/share/X11/xkb /usr/share/config
/var/qmail/control"
CONFIG_PROTECT_MASK="/etc/gconf /etc/revdep-rebuild /etc/terminfo /etc/env.d"
CXXFLAGS="-pipe -O2 -march=k8"
DISTDIR="/usr/distfiles"
FEATURES="autoconfig collision-protect digest distlocks metadata-transfer
nostrip sandbox sfperms strict userpriv usersandbox"
GENTOO_MIRRORS="http://distfiles.gentoo.org
http://distro.ibiblio.org/pub/linux/distributions/gentoo"
MAKEOPTS="-j3"
PKGDIR="/usr/portage/packages"
PORTAGE_TMPDIR="/var/tmp"
PORTDIR="/mnt/shapeshifter/portage"
PORTDIR_OVERLAY="/usr/local/portage"
SYNC="rsync://rsync.gentoo.org/gentoo-portage"
USE="amd64 64bit 7zip X a52 aac acpi aim alsa ao audiofile avi bash-completion
berkdb bitmap-fonts bzip2 c++ cairo calendar cddb cdparanoia cli clock-screen
crypt css ctype cups dba dbus debug dri dvd dvdr eds encode expat ext-png
ext-zlib fam fastbuild ffmpeg firefox flac foomaticdb force-cgi-redirect
fortran ftp gcj gd gdb gif glut glx gmail gpm grammar gstreamer gtalk gzip hal
id3 image imlib imlib2 input_devices_keyboard input_devices_mouse java
javascript jikes joystick jpeg jpeg2k kde key-screen lame libsamplerate
linuxkeys linuxthreads-tls live lzw lzw-tiff memlimit mmap mouse mozilla mozsvg
mp3 mpeg mpeg2 mplayer ncurses net nfs nntp no-old-linux nptl nptlonly nvidia
objc offensive ogg opengl openssh oscar pam pcre pdf pdflib perl png posix
python qt quicktime rar readline real reiser4 reiserfs rss rtc scp screen sdl
search-screen session simplexml smp soap sockets speedo speex spell spl ssl svg
svgz symlink sysfs syslog szip t1lib theora threads tiff tokenizer truetype
truetype-fonts type1 type1-fonts udev unicode usb utf8 video_cards_nv
video_cards_nvidia vim vim-with-x web wma wma123 wmf wordperfect xinerama xml
xpm xrandr xscreensaver xsl xv xvmc zip zlib elibc_glibc kernel_linux
userland_GNU"
Unset:  ASFLAGS, CTARGET, EMERGE_DEFAULT_OPTS, LANG, LC_ALL, LDFLAGS, LINGUAS

Created an attachment (id=83581) [edit]
gcc 4 patch

Upstream already has this as well

I tried applying that to simgear-0.3.9 and couldn't get it to patch cleanly.
Have I not had enough sleep?

Created an attachment (id=83642) [edit]
gcc-4.1 patch (take 2)

Nope, I screwed up :)

That patch compiles for me, thanks.

It maybe worthing thinking of bumping SimGear/FlighGear to 0.9.10-pre3 for
testing, because I just noticed FlightGear-0.9.9 has a similar GCC-4 issue.

Applied to portage, thanks for report and patch