Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 126151 - Missing Patch in x11-drivers/ati-drivers-8.23.7
Summary: Missing Patch in x11-drivers/ati-drivers-8.23.7
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: High normal (vote)
Assignee: X11 External Driver Maintainers
URL:
Whiteboard:
Keywords: InVCS
: 126185 (view as bug list)
Depends on:
Blocks:
 
Reported: 2006-03-14 06:08 UTC by Hanno Böck
Modified: 2006-03-20 17:02 UTC (History)
4 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
log of most recent emerge attempt, and the .config file for the kernel. (emerge.ati-drivers.error2.16.6rc6-mm2.tgz,11.14 KB, application/octet-stream)
2006-03-18 15:02 UTC, Michael Evans
Details
Log of trying to emerge ati-drivers and other possibly relevant files (.confure, etc) (emerge.ati-drivers.error2.16.6rc6-mm2.tgz,12.52 KB, application/octet-stream)
2006-03-18 15:35 UTC, Michael Evans
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Hanno Böck gentoo-dev 2006-03-14 06:08:56 UTC
* Cannot find $EPATCH_SOURCE!  Value for $EPATCH_SOURCE is:
 *
 *   /usr/portage/x11-drivers/ati-drivers/files/ati-drivers-8.23.7-intermodule.patch
 *   ( ati-drivers-8.23.7-intermodule.patch )


This patch is only applied on 2.6.16-rc-kernels. The patch from the old version (ati-drivers-8.22.5-intermodule.patch) can be used without any changes, so either copying that over or changing the patch to be unversioned should fix the issue.
Comment 1 Jakub Moc (RETIRED) gentoo-dev 2006-03-14 10:57:22 UTC
*** Bug 126185 has been marked as a duplicate of this bug. ***
Comment 2 Michael Evans 2006-03-16 15:48:47 UTC
This patch is missing, but after copying the old patch, running the digest on the package, etc.  It then breaks during compile.

The file responsible is...
/var/tmp/portage/ati-drivers-8.23.7/work/common/lib/modules/fglrx/build_mod/firegl_public.h

There is a line that looks like...
#if FIREGL_VMA_INFO

Which I take SHOULD be #ifdef instead, however I have no idea how to patch this file as it regenerates EVERY TIME I clean/compile the ebuild.

 * Found kernel source directory:
 *     /usr/src/linux
 * Found sources for kernel version:
 *     2.6.16-rc6-mm1
 * Checking for MTRR support enabled ...
  [ ok ]
 * Checking for AGP support enabled ...
  [ ok ]
 * Checking for DRM support disabled ...
  [ ok ]
 * X11 implementation is xorg-x11.
>>> Unpacking source...
 * Unpacking Ati drivers ...
  [ ok ]
 * Applying ati-drivers-8.23.7-intermodule.patch ...
  [ ok ]
>>> Source unpacked.
>>> Compiling source in /var/tmp/portage/ati-drivers-8.23.7 ...
 * Building the DRM module...
 * PLEASE UPDATE TO YOUR PACKAGE TO USE linux-info.eclass
 * PLEASE UPDATE TO YOUR PACKAGE TO USE linux-info.eclass
 * PLEASE UPDATE TO YOUR PACKAGE TO USE linux-info.eclass
 * PLEASE UPDATE TO YOUR PACKAGE TO USE linux-info.eclass
 * PLEASE UPDATE TO YOUR PACKAGE TO USE linux-info.eclass
 * PLEASE UPDATE TO YOUR PACKAGE TO USE linux-info.eclass
 * PLEASE UPDATE TO YOUR PACKAGE TO USE linux-info.eclass
 * PLEASE UPDATE TO YOUR PACKAGE TO USE linux-info.eclass
 * PLEASE UPDATE TO YOUR PACKAGE TO USE linux-info.eclass
 * PLEASE UPDATE TO YOUR PACKAGE TO USE linux-info.eclass
make: Entering directory `/usr/src/linux-2.6.16-rc6-mm1'
  CC [M]  /var/tmp/portage/ati-drivers-8.23.7/work/common/lib/modules/fglrx/build_mod/agp3.o
  CC [M]  /var/tmp/portage/ati-drivers-8.23.7/work/common/lib/modules/fglrx/build_mod/nvidia-agp.o
  CC [M]  /var/tmp/portage/ati-drivers-8.23.7/work/common/lib/modules/fglrx/build_mod/agpgart_be.o
/var/tmp/portage/ati-drivers-8.23.7/work/common/lib/modules/fglrx/build_mod/agpgart_be.c: In function `__fgl_agp_init':
/var/tmp/portage/ati-drivers-8.23.7/work/common/lib/modules/fglrx/build_mod/agpgart_be.c:8175: warning: `pm_register' is deprecated (declared at include/lin
ux/pm_legacy.h:16)
/var/tmp/portage/ati-drivers-8.23.7/work/common/lib/modules/fglrx/build_mod/agpgart_be.c: In function `__fgl_agp_cleanup':
/var/tmp/portage/ati-drivers-8.23.7/work/common/lib/modules/fglrx/build_mod/agpgart_be.c:8185: warning: `pm_unregister_all' is deprecated (declared at inclu
de/linux/pm_legacy.h:21)
/var/tmp/portage/ati-drivers-8.23.7/work/common/lib/modules/fglrx/build_mod/agpgart_be.c: At top level:
/var/tmp/portage/ati-drivers-8.23.7/work/common/lib/modules/fglrx/build_mod/agpgart_be.c:6079: warning: 'ati_gart_base' defined but not used
  CC [M]  /var/tmp/portage/ati-drivers-8.23.7/work/common/lib/modules/fglrx/build_mod/i7505-agp.o
  CC [M]  /var/tmp/portage/ati-drivers-8.23.7/work/common/lib/modules/fglrx/build_mod/firegl_public.o
In file included from /var/tmp/portage/ati-drivers-8.23.7/work/common/lib/modules/fglrx/build_mod/firegl_public.c:162:
/var/tmp/portage/ati-drivers-8.23.7/work/common/lib/modules/fglrx/build_mod/firegl_public.h:268:5: warning: "FIREGL_VMA_INFO" is not defined
/var/tmp/portage/ati-drivers-8.23.7/work/common/lib/modules/fglrx/build_mod/firegl_public.c:228: error: syntax error before string constant
/var/tmp/portage/ati-drivers-8.23.7/work/common/lib/modules/fglrx/build_mod/firegl_public.c:228: warning: type defaults to `int' in declaration of `MODULE_P
ARM'
/var/tmp/portage/ati-drivers-8.23.7/work/common/lib/modules/fglrx/build_mod/firegl_public.c:228: warning: function declaration isn't a prototype
/var/tmp/portage/ati-drivers-8.23.7/work/common/lib/modules/fglrx/build_mod/firegl_public.c:228: warning: data definition has no type or storage class
In file included from /var/tmp/portage/ati-drivers-8.23.7/work/common/lib/modules/fglrx/build_mod/drm_proc.h:41,
                 from /var/tmp/portage/ati-drivers-8.23.7/work/common/lib/modules/fglrx/build_mod/firegl_public.c:333:
/var/tmp/portage/ati-drivers-8.23.7/work/common/lib/modules/fglrx/build_mod/drmP.h:561:5: warning: "__HAVE_VBL_IRQ" is not defined
/var/tmp/portage/ati-drivers-8.23.7/work/common/lib/modules/fglrx/build_mod/drmP.h:664:5: warning: "__HAVE_VBL_IRQ" is not defined
/var/tmp/portage/ati-drivers-8.23.7/work/common/lib/modules/fglrx/build_mod/drmP.h:936:5: warning: "__HAVE_SG" is not defined
/var/tmp/portage/ati-drivers-8.23.7/work/common/lib/modules/fglrx/build_mod/firegl_public.c:409:5: warning: "FIREGL_VMA_INFO" is not defined
/var/tmp/portage/ati-drivers-8.23.7/work/common/lib/modules/fglrx/build_mod/firegl_public.c:428:5: warning: "FIREGL_VMA_INFO" is not defined
/var/tmp/portage/ati-drivers-8.23.7/work/common/lib/modules/fglrx/build_mod/firegl_public.c: In function `firegl_stub_open':
/var/tmp/portage/ati-drivers-8.23.7/work/common/lib/modules/fglrx/build_mod/firegl_public.c:534: warning: assignment discards qualifiers from pointer target
 type
/var/tmp/portage/ati-drivers-8.23.7/work/common/lib/modules/fglrx/build_mod/firegl_public.c: In function `firegl_stub_register':
/var/tmp/portage/ati-drivers-8.23.7/work/common/lib/modules/fglrx/build_mod/firegl_public.c:605: warning: assignment from incompatible pointer type
/var/tmp/portage/ati-drivers-8.23.7/work/common/lib/modules/fglrx/build_mod/firegl_public.c: At top level:
/var/tmp/portage/ati-drivers-8.23.7/work/common/lib/modules/fglrx/build_mod/firegl_public.c:3623: warning: initialization from incompatible pointer type
/var/tmp/portage/ati-drivers-8.23.7/work/common/lib/modules/fglrx/build_mod/firegl_public.c:3624: warning: initialization from incompatible pointer type
/var/tmp/portage/ati-drivers-8.23.7/work/common/lib/modules/fglrx/build_mod/firegl_public.c:3625: warning: initialization from incompatible pointer type
/var/tmp/portage/ati-drivers-8.23.7/work/common/lib/modules/fglrx/build_mod/firegl_public.c:3626: warning: initialization from incompatible pointer type
/var/tmp/portage/ati-drivers-8.23.7/work/common/lib/modules/fglrx/build_mod/firegl_public.c:3627: warning: initialization from incompatible pointer type
/var/tmp/portage/ati-drivers-8.23.7/work/common/lib/modules/fglrx/build_mod/firegl_public.c:3628: warning: initialization from incompatible pointer type
/var/tmp/portage/ati-drivers-8.23.7/work/common/lib/modules/fglrx/build_mod/firegl_public.c:3629: warning: initialization from incompatible pointer type
/var/tmp/portage/ati-drivers-8.23.7/work/common/lib/modules/fglrx/build_mod/firegl_public.c:3630: warning: initialization from incompatible pointer type
/var/tmp/portage/ati-drivers-8.23.7/work/common/lib/modules/fglrx/build_mod/firegl_public.c:3632: warning: initialization from incompatible pointer type
/var/tmp/portage/ati-drivers-8.23.7/work/common/lib/modules/fglrx/build_mod/firegl_public.c:3642: warning: function declaration isn't a prototype
/var/tmp/portage/ati-drivers-8.23.7/work/common/lib/modules/fglrx/build_mod/firegl_public.c: In function `test_inter_module_interface':
/var/tmp/portage/ati-drivers-8.23.7/work/common/lib/modules/fglrx/build_mod/firegl_public.c:3647: warning: assignment from incompatible pointer type
/var/tmp/portage/ati-drivers-8.23.7/work/common/lib/modules/fglrx/build_mod/firegl_public.c: In function `__ke_agp_allocate_memory_phys_list':
/var/tmp/portage/ati-drivers-8.23.7/work/common/lib/modules/fglrx/build_mod/firegl_public.c:3972: warning: passing arg 3 of pointer to function makes intege
r from pointer without a cast
/var/tmp/portage/ati-drivers-8.23.7/work/common/lib/modules/fglrx/build_mod/firegl_public.c: In function `__ke_agp_bind_memory':
/var/tmp/portage/ati-drivers-8.23.7/work/common/lib/modules/fglrx/build_mod/firegl_public.c:4011: warning: passing arg 1 of pointer to function from incompa
tible pointer type
/var/tmp/portage/ati-drivers-8.23.7/work/common/lib/modules/fglrx/build_mod/firegl_public.c: In function `__ke_agp_unbind_memory':
/var/tmp/portage/ati-drivers-8.23.7/work/common/lib/modules/fglrx/build_mod/firegl_public.c:4024: warning: passing arg 1 of pointer to function from incompa
tible pointer type
make[1]: *** [/var/tmp/portage/ati-drivers-8.23.7/work/common/lib/modules/fglrx/build_mod/firegl_public.o] Error 1
make: *** [_module_/var/tmp/portage/ati-drivers-8.23.7/work/common/lib/modules/fglrx/build_mod] Error 2
make: Leaving directory `/usr/src/linux-2.6.16-rc6-mm1'
 * DRM module not built
 * PLEASE UPDATE TO YOUR PACKAGE TO USE linux-info.eclass
 * PLEASE UPDATE TO YOUR PACKAGE TO USE linux-info.eclass
 * PLEASE UPDATE TO YOUR PACKAGE TO USE linux-info.eclass
 * PLEASE UPDATE TO YOUR PACKAGE TO USE linux-info.eclass
 * PLEASE UPDATE TO YOUR PACKAGE TO USE linux-info.eclass
 * PLEASE UPDATE TO YOUR PACKAGE TO USE linux-info.eclass
 * PLEASE UPDATE TO YOUR PACKAGE TO USE linux-info.eclass
 * PLEASE UPDATE TO YOUR PACKAGE TO USE linux-info.eclass
 * PLEASE UPDATE TO YOUR PACKAGE TO USE linux-info.eclass
 * PLEASE UPDATE TO YOUR PACKAGE TO USE linux-info.eclass
>>> Source compiled.


Portage 2.1_pre6-r3 (default-linux/x86/2005.0, gcc-3.4.5, glibc-2.4-r0, 2.6.16-rc6-mm1 i686)
=================================================================
System uname: 2.6.16-rc6-mm1 i686 AMD Athlon(tm) 64 Processor 3000+
Gentoo Base System version 1.12.0_pre16
dev-lang/python:     2.3.5, 2.4.2-r1
sys-apps/sandbox:    1.2.17
sys-devel/autoconf:  2.13, 2.59-r7
sys-devel/automake:  1.4_p6, 1.5, 1.6.3, 1.7.9-r1, 1.8.5-r3, 1.9.6-r1
sys-devel/binutils:  2.16.1-r2
sys-devel/libtool:   1.5.22
virtual/os-headers:  2.6.11-r3
ACCEPT_KEYWORDS="x86 ~x86"
AUTOCLEAN="yes"
CBUILD="i686-pc-linux-gnu"
CFLAGS="-O2 -march=athlon-xp -fomit-frame-pointer -pipe"
CHOST="i686-pc-linux-gnu"
CONFIG_PROTECT="/etc /usr/kde/2/share/config /usr/kde/3.4/env /usr/kde/3.4/share/config /usr/kde/3.4/shutdown /usr/kde/3.5/env /usr/kde/3.5/share/config /usr/kde/3.5/shutdown /usr/kde/3/share/config /usr/lib/X11/xkb /usr/share/config /var/qmail/control"
CONFIG_PROTECT_MASK="/etc/gconf /etc/revdep-rebuild /etc/terminfo /etc/env.d"
CXXFLAGS="-O2 -march=athlon-xp -fomit-frame-pointer -pipe"
DISTDIR="/usr/portage/distfiles"
FEATURES="autoconfig distlocks metadata-transfer sandbox sfperms strict"
GENTOO_MIRRORS="http://gentoo.osuosl.org/ http://gd.tuwien.ac.at/opsys/linux/gentoo/ ftp://mirrors1.netvisao.pt/gentoo/ http://gentoo.math.bme.hu"
MAKEOPTS="-j2"
PKGDIR="/usr/portage/packages"
PORTAGE_TMPDIR="/var/tmp"
PORTDIR="/portagetree"
SYNC="rsync://rsync.gentoo.org/gentoo-portage"
USE="x86 3dnow X Xaw3d a52 aac acl acpi alsa apache2 apm avi bash-completion berkdb bidi bitmap-fonts bzip2 caps cdparanoia cdr cjk crypt css cups dga dri dv dvd dvdr eds emboss encode ethereal exif fftw flac flash foomaticdb fortran freetds freewnn gdbm gif ginac gnome gphoto2 gpm gstreamer gtk gtk2 ieee1394 imagemagick imlib innodb ipv6 java joystick jpeg kde libg++ libwww lm_sensors mad maildir matroska memlimit mikmod mime ming mmx motif mp3 mpeg mpi mysql mysqli ncurses nls nocd nptl nptlonly odbc offensive ogg oggvorbis openal opengl oss pam pcntl pcre pdflib perl png posix ppds python qt quicktime readline recode scanner sdl server session shorten skey slang sockets socks5 spell sse sse2 ssl sysvipc szip tcltk tcpd theora threads tiff truetype truetype-fonts type1-fonts unicode usb vorbis win32codecs wmf xine xml xml2 xmms xv xvid zlib elibc_glibc kernel_linux userland_GNU"
Unset:  ASFLAGS, CTARGET, EMERGE_DEFAULT_OPTS, LANG, LC_ALL, LDFLAGS, LINGUAS, PORTDIR_OVERLAY
Comment 3 Michael Evans 2006-03-16 15:55:31 UTC
Didn't notice it the first time... however this is misused in EVERY instance as well.

localhost ati-drivers-8.23.7 # grep -ri "FIREGL_VMA_INFO" .
grep: ./distdir/ati-driver-installer-8.23.7-x86_64.run: No such file or directory
./work/common/lib/modules/fglrx/build_mod/firegl_public.c:#if FIREGL_VMA_INFO
./work/common/lib/modules/fglrx/build_mod/firegl_public.c:#if FIREGL_VMA_INFO
./work/common/lib/modules/fglrx/build_mod/firegl_public.h:#if FIREGL_VMA_INFO
./work/common/lib/modules/fglrx/build_mod/firegl_agpgart/firegl_wrapper.h:#define FIREGL_VMA_INFO  1                  // enable /proc/dri/0/vma
Comment 4 Cyrill Helg 2006-03-18 04:13:31 UTC
Copying of the patch works here. Why did the maintainer forget about the patch? 
Comment 5 Michael Evans 2006-03-18 15:02:11 UTC
Created attachment 82497 [details]
log of most recent emerge attempt, and the .config file for the kernel.
Comment 6 Michael Evans 2006-03-18 15:04:47 UTC
I guess it doesn't take These comments as well when you create an attachment.  I thought it might return me here to finish writing, so I'll begin again.

I emerge --synced about 20 min ago.  Updated everything (except ati-drivers which failed to emerge), copied my old .config to the latest mm-sources kernel, make oldconfig, genkernel --install --no-clean all, emerge ati-drivers (and logged it's output.)
Comment 7 Michael Evans 2006-03-18 15:34:15 UTC
Comment on attachment 82497 [details]
log of most recent emerge attempt, and the .config file for the kernel.

Syntax error in bash let stderr escape capture...
Comment 8 Michael Evans 2006-03-18 15:35:52 UTC
Created attachment 82502 [details]
Log of trying to emerge ati-drivers and other possibly relevant files (.confure, etc)

The patch included in this file is not from the portage tree, The file is missing on the portage tree, so I had to copy the most recent patch in to it's place.
Comment 9 FieldySnuts 2006-03-20 05:52:30 UTC
I am also seeing this issue. Kernel 2.6.16-ifc. ifc is just a one-file patch to
acpi to enable better fan speed control on my laptop.

Gentoo Base System version 1.6.14
Portage 2.1_pre6-r3 (default-linux/x86/2006.0, gcc-3.4.5, glibc-2.3.6-r3, 2.6.16-ifc i686)
=================================================================
System uname: 2.6.16-ifc i686 Intel(R) Pentium(R) M processor 1.86GHz
distcc 2.18.3 i686-pc-linux-gnu (protocols 1 and 2) (default port 3632) [enabled]
ccache version 2.3 [enabled]
dev-lang/python:     2.3.5-r2, 2.4.2
sys-apps/sandbox:    1.2.17
sys-devel/autoconf:  2.13, 2.59-r7
sys-devel/automake:  1.4_p6, 1.5, 1.6.3, 1.7.9-r1, 1.8.5-r3, 1.9.6-r1
sys-devel/binutils:  2.16.1-r2
sys-devel/libtool:   1.5.22
virtual/os-headers:  2.6.11-r3
ACCEPT_KEYWORDS="x86"
AUTOCLEAN="yes"
CBUILD="i686-pc-linux-gnu"
CFLAGS="-Os -march=pentium-m -fomit-frame-pointer -pipe"
CHOST="i686-pc-linux-gnu"
CONFIG_PROTECT="/etc /usr/kde/2/share/config /usr/kde/3.5/env /usr/kde/3.5/share/config /usr/kde/3.5/shutdown /usr/kde/3/share/config /usr/lib/mozilla/defaults/pref /usr/share/X11/xkb /usr/share/config /var/qmail/control"
CONFIG_PROTECT_MASK="/etc/gconf /etc/terminfo /etc/env.d"
CXXFLAGS="-Os -march=pentium-m -fomit-frame-pointer -pipe"
DISTDIR="/usr/portage/distfiles"
FEATURES="autoconfig ccache collision-protect distcc distlocks metadata-transfer sandbox sfperms strict"
GENTOO_MIRRORS="http://gentoo.chem.wisc.edu/gentoo/ ftp://gentoo.chem.wisc.edu/gentoo/ http://ftp.belnet.be/mirror/rsync.gentoo.org/gentoo/ ftp://ftp.rhnet.is/pub/gentoo/ http://ftp.rhnet.is/pub/gentoo/"
MAKEOPTS="-j4"
PKGDIR="/usr/portage/packages"
PORTAGE_TMPDIR="/var/tmp"
PORTDIR="/usr/portage"
PORTDIR_OVERLAY="/usr/local/portage"
SYNC="rsync://rsync.namerica.gentoo.org/gentoo-portage"
USE="x86 3dnow X a52 alsa apache2 apm avi berkdb bitmap-fonts cdr chroot cli crypt ctype dba dri dv dvd dvdr dvdread eds emboss encode expat fastbuild foomaticdb force-cgi-redirect fortran ftp gd gdbm gif gpm gstreamer gtk gtk2 hal imlib jpeg kde kdeenablefinal libg++ libwww mad memlimit mikmod mmx motif mp3 mpeg ncurses network nls nptl ogg oggvorbis opengl pam pcre pdflib perl png posix pwdb python qt quicktime readline sdl session simplexml soap sockets spell spl sse ssl theora tiff tokenizer truetype truetype-fonts type1-fonts udev vorbis xml xmms xsl xv zlib elibc_glibc input_devices_keyboard input_devices_mouse input_devices_synaptics kernel_linux userland_GNU video_cards_ati"
Unset:  ASFLAGS, CTARGET, EMERGE_DEFAULT_OPTS, LANG, LC_ALL, LDFLAGS, LINGUAS
Comment 10 Michael Evans 2006-03-20 06:49:34 UTC
The ATI driver seems to be using an older module interface...  It looks like it's failing here...

/var/tmp/portage/ati-drivers-8.23.7/work/common/lib/modules/fglrx/build_mod/firegl_public.c
MODULE_PARM(firegl, "s");

When most modules in the kernel that call it use an integer instead.

I should also note that I used diff to compare the .h files I suspected between a kernel this would compile against, and one it would not.  (Same .config aside from make oldconfig) and could not determine any difference.
Comment 11 Jory A. Pratt 2006-03-20 17:02:03 UTC
This is fixed in CVS but is not the complete or even proper solution as of yet. Next release we will use a pkg_setup and die if ati-drivers is known to fail on a particular kernel release.