Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 124355 - app-emulation/xen needs pae local use flag
Summary: app-emulation/xen needs pae local use flag
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: New packages (show other bugs)
Hardware: All Other
: High enhancement (vote)
Assignee: Chris Bainbridge (RETIRED)
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2006-02-27 21:49 UTC by Christopher G. Stach II
Modified: 2006-04-10 06:27 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
xen-3.0.1-r1.patch (xen-3.0.1-r1.patch,1.67 KB, patch)
2006-02-28 12:03 UTC, Christopher G. Stach II
Details | Diff
gentoo-make.patch (gentoo-make.patch,407 bytes, patch)
2006-02-28 12:04 UTC, Christopher G. Stach II
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Christopher G. Stach II 2006-02-27 21:49:21 UTC
Xen by default is not build with PAE capabilities.  The Xen README gives details on how to build Xen to support PAE for machines with >4GiB of memory.
Comment 1 Chris Bainbridge (RETIRED) gentoo-dev 2006-02-28 07:28:32 UTC
I don't have a PAE-ised >4gb system; if you can supply a tested patch for the ebuild I'll add it.
Comment 2 Christopher G. Stach II 2006-02-28 12:01:59 UTC
We should also force the xen-sources dom0 and guest kernels to compile with PAE.  Dom0 and xen must match, and I don't think that xen yet supports non-PAE kernels in PAE xen.  It doesn't work for me.
Comment 3 Christopher G. Stach II 2006-02-28 12:03:58 UTC
Created attachment 80957 [details, diff]
xen-3.0.1-r1.patch
Comment 4 Christopher G. Stach II 2006-02-28 12:04:22 UTC
Created attachment 80958 [details, diff]
gentoo-make.patch
Comment 5 Christopher G. Stach II 2006-02-28 12:05:14 UTC
"pae" should probably be a global USE flag, since it affects both of the xen packages, huh?
Comment 6 Chris Bainbridge (RETIRED) gentoo-dev 2006-03-02 03:51:45 UTC
I've added pae support. The pae flag is only on xen - a warning is shown that it will only boot pae kernels. There's really no way to force the user to build a pae kernel, we just assume that they know what they're doing. Also global use flags only get added when at least 5 packages are already using them.

I dropped your patch - maintaining a patch is more hassle than the 2 lines of the ebuild it saves.

Thanks for your contribution!
Comment 7 Christopher G. Stach II 2006-03-02 09:34:54 UTC
Unless their Makefile changed (I haven't synched with portage yet), your changes won't work.  I modified the Makefile because XEN_TARGET_X86_PAE=y is actually refenced in the root Makefile, not the ones in the subdirectories.  It sets the variable pae=y, and the other Makefiles use that.
Comment 8 Chris Bainbridge (RETIRED) gentoo-dev 2006-03-03 04:21:43 UTC
Ok, it should be fixed now.
Comment 9 Christopher G. Stach II 2006-03-30 19:07:19 UTC
Looks like the ebuild for p9029 got goofed up for PAE.
Comment 10 Chris Bainbridge (RETIRED) gentoo-dev 2006-03-31 00:55:29 UTC
I don't see any changes that would affect PAE?
Comment 11 Christopher G. Stach II 2006-03-31 00:56:49 UTC
I had to change the opts XEN_blah=y back to pae=y.
Comment 12 Aron Griffis (RETIRED) gentoo-dev 2006-04-01 06:28:53 UTC
(In reply to comment #11)
> I had to change the opts XEN_blah=y back to pae=y.

Could you explain more?  The only difference between the 9029-r2.ebuild and the 3.0.1_p9029.ebuild wrt pae is that the former used

	if use pae; then
		myopt="${myopt} XEN_TARGET_X86_PAE=y"
	fi

and the latter uses

	use pae && myopt="${myopt} XEN_TARGET_X86_PAE=y"

These should be functionally equivalent, so what's the issue again?
Comment 13 Christopher G. Stach II 2006-04-01 10:04:22 UTC
The main Makefile isn't used.  It sets pae=y based on XEN_TARGET_X86_PAE.  Without pae=y during the compile, it can't link successfully.  See me post at 2006-03-02 09:34 PST.
Comment 14 Chris Bainbridge (RETIRED) gentoo-dev 2006-04-10 06:27:16 UTC
Should be fixed in 3.0.2. I just set pae=y in the ebuild... it seems to compile okay and it's using the PAE flags, so hopefully nothing else changed.