(Assigning this to klieber / ramereth since bugzilla doesn't like sysadmin@ as a n assignee. Does it have a bugzilla account?) From cfengine-2.1.18.ebuild: pkg_postinst() {
(Assigning this to klieber / ramereth since bugzilla doesn't like sysadmin@ as a n assignee. Does it have a bugzilla account?) From cfengine-2.1.18.ebuild: pkg_postinst() { »···if [ ! -f "/var/cfengine/ppkeys/localhost.priv" ] »···»···then »···»···einfo "Generating keys for localhost." »···»···/usr/sbin/cfkey »···fi This needs to be updated to honour $ROOT. Does cfkey provide an easy way of changing the output location? »···cp /usr/sbin/cf{agent,servd,execd} /var/cfengine/bin/ Same here. Can this one not be moved to src_install? Another minor issue, since I'm filing a bug anyway: we try to avoid using dodoc on INSTALL files unless they contain something particularly useful.
(In reply to comment #0) > (Assigning this to klieber / ramereth since bugzilla doesn't like sysadmin@ as > a n assignee. Does it have a bugzilla account?) That probably needs to be updated. I don't think its a valid herd. > From cfengine-2.1.18.ebuild: > > pkg_postinst() { >
(In reply to comment #0) > (Assigning this to klieber / ramereth since bugzilla doesn't like sysadmin@ as > a n assignee. Does it have a bugzilla account?) That probably needs to be updated. I don't think its a valid herd. > From cfengine-2.1.18.ebuild: > > pkg_postinst() { > »···if [ ! -f "/var/cfengine/ppkeys/localhost.priv" ] > »···»···then > »···»···einfo "Generating keys for localhost." > »···»···/usr/sbin/cfkey > »···fi Yup, that needs changed. I'll get to that. > This needs to be updated to honour $ROOT. Does cfkey provide an easy way of > changing the output location? Unforunately, I don't see any option for cfkey to change the default location of that. I will need to ask upstream about this most likely. > »···cp /usr/sbin/cf{agent,servd,execd} /var/cfengine/bin/ > > > Same here. Can this one not be moved to src_install? I would think so unless Kurt remembers why we did it this way. > Another minor issue, since I'm filing a bug anyway: we try to avoid using dodoc > on INSTALL files unless they contain something particularly useful. There's a few useful things near the top that mentions needing the newest version of openssl and db before installing. I'm not sure if that falls under the "particularly useful" category or not, but its better than just the default file without anything added to it. Thanks for pointing these QA issues out.
Created attachment 80870 [details, diff] cfengine-2.1.18-cfkey-root.patch This patch should allow you todo use cfkey with an alt root prefix. It changes the handling of the cfkey so that the first argv is assumed to be the prefix for the CFWORKDIR. In the ebuild you will want todo something like # Note the trailing slash cfkey ${ROOT}/
Ramereth/klieber: does this patch work for you? :)
I tried it a while back and had a few issues getting it to patch right. I was working on fixing the patch but never got it completed. Been on my todo list to finish.
klieber/ramereth: Any update here?
marineam: You did a couple of commits to this package. Do you want to fix this issue for us, and do you want to maintain this package? Unless ramereth or klieber want to take it back :) This is a pretty old bug, so lets do something with it soon please.
(In reply to comment #8) > marineam: You did a couple of commits to this package. Do you want to fix this > issue for us, and do you want to maintain this package? Unless ramereth or > klieber want to take it back :) > > This is a pretty old bug, so lets do something with it soon please. > Hm, either I'll start maintaining the package or I'll start shooting Ramereth in the back of the head with nerf darts until he takes it back. Either way someone will take it.
marineam: So...what's going on? :) Someone want to take this package? I don't want to apply changes like this without someone familiar with the package checking it out first.
Sorry for my neglect with this package and this patch. I'll take a look at it soon and see how it works. Thanks-
Running cfkey really belongs in pkg_config. With that being said, so the files it produce still need to honor $ROOT? I have a feeling that upstream may have a problem accepting this patch since it breaks their security model. I could just make it a gentoo specfic patch, but I'd rather not do that. Is there any other way I can get around this problem? I would think moving it to pkg_config would at least minimize the issue a lot more.
cfkey has been moved to pkg_config now.
