First Last Prev Next    No search results available      Search page      Enter new bug
Bug#: 122566
Alias:
Product:
Component:
Status: RESOLVED
Resolution: FIXED
Assigned To: Gentoo's Team for Core System packages <base-system@gentoo.org>
Hardware:
OS:
Version:
Priority:
Severity:
Reporter: Ed Catmur <ed@catmur.co.uk>
Add CC:
CC:
Remove selected CCs
URL:
Summary:
Status Whiteboard:
Keywords:

Filename Description Type Creator Created Size Actions
ncurses-terminfo-gnome-rs1.patch ncurses-terminfo-gnome-rs1.patch patch Ed Catmur 2006-02-12 08:29 0000 484 bytes Details | Diff
ncurses-terminfo-gnome-rs1-rs2.patch ncurses-terminfo-gnome-rs1-rs2.patch patch Ed Catmur 2006-05-01 03:41 0000 609 bytes Details | Diff
Create a New Attachment (proposed patch, testcase, etc.) View All

Bug 122566 depends on: Show dependency tree
Bug 122566 blocks: 91055 119872
Votes: 0    Show votes for this bug    Vote for this bug

Additional Comments: (this is where you put emerge --info)


Not eligible to see or edit group visibility for this bug.






View Bug Activity   |   Format For Printing   |   XML   |   Clone This Bug


Description:   Opened: 2006-02-12 08:28 0000
The terminfo entry for "gnome" does not set rs1. This is needed for reset, etc.

$ infocmp -Ix gnome | grep rs1
$

This will become an issue when gnome-terminal 2.14.x comes out, as it will set
TERM="gnome" (dang says so).

Also, the entries for kDN,kDN5,kLFT5 etc. are incorrect, though they aren't
used much.

I attach a patch.

------- Comment #1 From Ed Catmur 2006-02-12 08:29:23 0000 -------
Created an attachment (id=79571) [edit]
ncurses-terminfo-gnome-rs1.patch

------- Comment #2 From SpanKY 2006-02-12 09:58:48 0000 -------
Thomas would be the goto guy for this

------- Comment #3 From John N. Laliberte (RETIRED) 2006-03-29 17:59:26 0000 -------
@Thomas: is it possible to add this patch upstream for us?

Thanks!

------- Comment #4 From Ed Catmur 2006-05-01 03:40:45 0000 -------
Another problem: rs2 fails to reset the charset.

$ cat /dev/urandom
(prompt turns to garbage)
$ reset               <---typing blind
(screen clears, prompt still garbage)
$ TERM=xterm reset    <---typing blind
(screen clears, prompt now OK)

The difference is that xterm rs2 has <ESC>[!p, which resets the charset. I'll
attach a patch to do the same for the gnome entry.

------- Comment #5 From Ed Catmur 2006-05-01 03:41:22 0000 -------
Created an attachment (id=85901) [edit]
ncurses-terminfo-gnome-rs1-rs2.patch

Combined patch.

------- Comment #6 From Gilles Dartiguelongue 2006-06-15 07:23:49 0000 -------
hum, I am running gnome 2.14 and I do not see this issue.

------- Comment #7 From Ed Catmur 2006-06-15 08:33:25 0000 -------
The TERM="gnome" patch got punted. Long-term it's still correct, though.

------- Comment #8 From Thomas Dickey 2006-06-20 06:36:47 0000 -------
The rs1=\Ec, I guess so.

The \E[!p probably not.  Unless GNOME developers start documenting features
of gnome-terminal, there's no easy way to determine which version of the
program the feature applies to (hint: this isn't a "vt220 cursor movement"
string).

------- Comment #9 From Ed Catmur 2006-06-23 14:36:30 0000 -------
\E[!p has been there since vte got imported into gnome cvs:
http://cvs.gnome.org/viewcvs/vte/src/caps.c?annotate=1.26

I think it's a pretty safe bet that anything out there calling itself gnome
supports \E[!p.

------- Comment #10 From Thomas Dickey 2006-06-23 15:48:57 0000 -------
Perhaps (it may recognize the sequence, but without testing,
(or reading the source code). I wouldn't know if it behaves as
reported.  That particular file only tells gnome-terminal
that it's a known sequence (I can recall when it wasn't ;-).
However, I have a copy of vte-0.11.10 (from 2002) at hand, and
see that sequence is supposed to call vte_terminal_reset() - a table
in src/vte.c - which does something to the iso2022 character settings.
Reading a little further, I note that what it actually does is mostly
incompatible with vt220, but will reset _some_ of the graphics characters,
which is the intent of this bug report...

------- Comment #11 From Ed Catmur 2006-06-24 05:22:03 0000 -------
Uh, OK. \E[!p was implemented in May 2002:
http://cvs.gnome.org/viewcvs/vte/src/vte.c?r1=1.93&r2=1.94

Still, I don't see how emitting \E[!p for rs2 will break anything.

------- Comment #12 From Thomas Dickey 2006-06-24 05:33:52 0000 -------
I agree - it might do what you want.

------- Comment #13 From Thomas Dickey 2006-06-24 11:23:26 0000 -------
hmm - I have a Fedora Core 5, but no GenToo.  However, FC5 has
gnome-terminal 2.14.2, which sets TERM to "xterm".  The first
comment must refer to a GenToo patch.

------- Comment #14 From Ed Catmur 2006-06-24 13:20:57 0000 -------
Yes. See http://bugs.gentoo.org/show_bug.cgi?id=91055 - once this bug is fixed
Gentoo will patch gnome-terminal to set TERM="gnome". Hopefully after that we
can get Gnome to do the same. (History: the development 2.13.x ebuilds had the
patch, but it was punted from 2.14.x because of this bug.)

------- Comment #15 From SpanKY 2006-06-24 16:48:29 0000 -------
so Thomas, this patch here is correct ?

------- Comment #16 From Thomas Dickey 2006-06-25 02:42:37 0000 -------
It's ok.  I adapted it (split-out the reusable chunks), and put a
copy in ftp://invisible-island.net/ncurses/terminfo.src.gz

------- Comment #17 From SpanKY 2006-06-26 23:13:22 0000 -------
5.5-r3 now in portage

First Last Prev Next    No search results available      Search page      Enter new bug