Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 122038 - jing jar missing META-INF/services
Summary: jing jar missing META-INF/services
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: New packages (show other bugs)
Hardware: All Linux
: High normal (vote)
Assignee: Java team
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2006-02-07 13:39 UTC by James Riordan
Modified: 2007-01-20 19:57 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments
bug example (jing-test.tar,10.00 KB, application/octet-stream)
2006-02-07 13:42 UTC, James Riordan
Details
patch (jing.patch,3.31 KB, patch)
2006-02-07 14:02 UTC, James Riordan
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description James Riordan 2006-02-07 13:39:39 UTC
The jing ebuild does not generate META-INF/services for the jing jar file.  This breaks the use of external datatypes (e.g. dtd:*, xsd:*).

As a quick fix, the services can be grabbed from the jing.jar file (included in the distfile)

jar xvf /usr/share/jing/lib/jing.jar META-INF/services

and copied into the build tree in build.xml
Comment 1 James Riordan 2006-02-07 13:42:33 UTC
Created attachment 79167 [details]
bug example

Validation should fail due to the non-unique ID.
Comment 2 James Riordan 2006-02-07 14:02:04 UTC
Created attachment 79169 [details, diff]
patch

ebuild patch to grab the META-INF/services from the distributed jar
Comment 3 Josh Nichols (RETIRED) gentoo-dev 2006-02-07 15:07:08 UTC
(In reply to comment #2)
> Created an attachment (id=79169) [edit]
> patch
> 
> ebuild patch to grab the META-INF/services from the distributed jar
> 

When supplying patches, it is better to not do reformatting changes (ie fix tabs, change tabs to spaces, etc). Otherwise, it makes it difficult to see what parts you actually changed, and weren't just reformatting.
Comment 4 James Riordan 2006-02-08 01:43:27 UTC
Comment on attachment 79169 [details, diff]
patch

diff -Narub /usr/local/portage-local/app-text/jing/files/build.xml /usr/portage/app-text/jing/files/build.xml
--- /usr/local/portage-local/app-text/jing/files/build.xml	2006-02-07 22:54:51.000000000 +0100
+++ /usr/portage/app-text/jing/files/build.xml	2004-11-14 15:56:27.000000000 +0100
@@ -5,11 +5,11 @@
   <target name="compile">
     <mkdir dir="build" />
     
-    <javac srcdir="src" destdir="build" source="1.4">
+		<javac srcdir="src" 
+			destdir="build"
+			source="1.4">
       <classpath>
-	<pathelement path="bin/isorelax.jar"/>
-	<pathelement path="bin/saxon.jar"/>
-	<pathelement path="bin/xerces.jar"/>
+				<pathelement path="bin/isorelax.jar:bin/saxon.jar:bin/xerces.jar" />
       </classpath>
     </javac>
     
@@ -20,10 +20,6 @@
 	<include name="**/*.properties" />
       </fileset>
     </copy>
-
-    <copy todir="build/META-INF">
-      <fileset dir="META-INF"/>
-    </copy>
   </target>
 
   <!-- create the jar archive -->
diff -Narub /usr/local/portage-local/app-text/jing/jing-20030619-r1.ebuild /usr/portage/app-text/jing/jing-20030619-r1.ebuild
--- /usr/local/portage-local/app-text/jing/jing-20030619-r1.ebuild	2006-02-07 22:51:55.000000000 +0100
+++ /usr/portage/app-text/jing/jing-20030619-r1.ebuild	2006-01-22 06:35:26.000000000 +0100
@@ -30,10 +30,7 @@
 	epatch ${FILESDIR}/build-patch.diff
 	epatch ${FILESDIR}/${P}-xerces.patch
 
-	cd ..
-	jar xvf bin/jing.jar META-INF/services
-	cd bin/
-
+	cd ../bin/
 	rm -f *.jar
 	java-pkg_jar-from iso-relax
 	java-pkg_jar-from xerces-1.3 xerces.jar
diff -Narub /usr/local/portage-local/app-text/jing/Manifest /usr/portage/app-text/jing/Manifest
--- /usr/local/portage-local/app-text/jing/Manifest	2006-02-07 22:55:14.000000000 +0100
+++ /usr/portage/app-text/jing/Manifest	2006-01-22 06:35:26.000000000 +0100
@@ -1,8 +1,18 @@
+-----BEGIN PGP SIGNED MESSAGE-----
+Hash: SHA1
+
 MD5 650f7673064f96e185224d6cd1b9ad1f ChangeLog 1966
 MD5 4e01494f4274dfe8fbed0b4982405537 files/build-patch.diff 1484
-MD5 0e25c681445a43afae6909f6b7190695 files/build.xml 856
+MD5 9ca0559020eae581281496f04c53dd7b files/build.xml 710
 MD5 a2004d054506b2ec4e8add35ec84dc44 files/digest-jing-20030619-r1 63
 MD5 16d1fac29c56d57e0eee5aecefee4fcf files/jing-20030619-xerces.patch 1393
 MD5 60267d864fc6a05822d8b732ff12e8dd files/manifest.mf 136
-MD5 26513c54505682006356fb258b2e8785 jing-20030619-r1.ebuild 1516
+MD5 e1836574ad24fe4864d2d3f14b588803 jing-20030619-r1.ebuild 1471
 MD5 79a5dd1b805e5bca495aec6d6a73826b metadata.xml 176
+-----BEGIN PGP SIGNATURE-----
+Version: GnuPG v1.4.2 (GNU/Linux)
+
+iD8DBQFD0xW/ndWRXhKOboURAhsWAKDTpOmxdJRrw1EnuD/qFepK/ryWCACdHhiE
+afjXxWIOwmk8CkDJaPlV0C0=
+=47Z+
+-----END PGP SIGNATURE-----
Comment 5 Petteri Räty (RETIRED) gentoo-dev 2007-01-20 19:57:07 UTC
+*jing-20030619-r3 (20 Jan 2007)
+
+  20 Jan 2007; Petteri Räty <betelgeuse@gentoo.org> +files/build-r1.xml,
+  +jing-20030619-r3.ebuild:
+  Fixed bug #122038, made this compile with jdks >=1.5, cleaned the ebuild and
+  added the source use flag.
+

The services files are included in src.jar so I took them from there and adjusted the build.xml file to copy them to build/. Better later than never.