This ebuild contains Mup-5.2, a music notation program. A patch to correct a small bug is also included.
Created attachment 79012 [details] ebuild for mup 5.2-r1
Please attach the patch as text/plain and explain the bug that it corrects. Also, there is no need to attach the digest. As for the ebuild... use plain/text for that too. If you attach a diff against the previous ebuild, it is easy to see what you have changed. See http://dev.gentoo.org/~ciaranm/docs/mw-faq/attachments.txt -- Your ebuild needs to contain a header that matches /usr/portage/header.txt. The one you submitted just copies the header in mup-4.6.ebuild. See http://dev.gentoo.org/~ciaranm/docs/mw-faq/header.txt -- The ebuild should be named mup-5.2.ebuild and not mup-5.2-r1.ebuild because there is no mup-5.2.ebuild in the tree. See "Versioning and revision bumps" in http://www.gentoo.org/proj/en/devrel/handbook/handbook.xml?part=3&chap=1 -- KEYWORDS should be "~x86". New packages always start off in ~arch. There are no exceptions for stuff that is "really simple", "obviously stable" or "working". See http://dev.gentoo.org/~ciaranm/docs/mw-faq/keywords.txt -- This ebuild is not ported to modular X. Take a look at DEPEND/RDEPEND in mup-5.1.ebuild. mup-5.1.ebuild is already ported to modular X. See http://www.gentoo.org/proj/en/desktop/x/x11/porting-modular-x-howto.xml -- For the line: epatch ${FILESDIR}/mup-5.2-fontfamily-with.patch You should use ${P} instead of hardcoding the package name and version. See http://dev.gentoo.org/~plasmaroo/devmanual//ebuild-writing/variables/ -- You need to define compile time dependencies (DEPEND). According to your ebuild this program can be compiled on any system with a basic toolchain. However, to compile mup one needs X libraries installed, if the X USE flag is enabled. See http://dev.gentoo.org/~plasmaroo/devmanual//general-concepts/dependencies/ -- You should use "use svga" instead of "[ `use svga` ]", it is more readable. -- Please close Bug #18636 as it is a duplicate. -- Thank you for taking the time to submit the ebuild and consider these suggestions! If you need any help #gentoo-dev-help on irc.freenode.net, http://dev.gentoo.org/~ciaranm/docs/mw-faq/ , http://dev.gentoo.org/~plasmaroo/devmanual/ , and http://www.gentoo.org/proj/en/devrel/handbook/handbook.xml are all very useful resources.
Created attachment 80102 [details, diff] diff from mup 5.1 ebuild to 5.2 ebuild I hope I implemented al requests correcly :-) Will attach the fontfamily patch hereafter.
Created attachment 80103 [details, diff] fontfamily in [with...] -patch This patch corrects a bug in Mup so that the [with "text"] construct correctly uses the specified fontfamily for the text.
Created attachment 81091 [details, diff] diff from mup 5.1 ebuild to 5.2 ebuild Updated mup 5.2 (still 5.2 because it wasn't yet in the tree). This ebuild adds a patch that resolves a little bug that in rare circumstances a key change was not printed.
Created attachment 81092 [details, diff] this patch resolves a little bug that in rare circumstances a key change was not printed.
Created attachment 96551 [details, diff] Updated diff to include ~amd64 keyword The proposed ebuild works (builds and runs) fine on amd64, so I have added the ~amd64 keyword
Created attachment 114540 [details] my (working) mup 5.3 ebuild I lost my original mup-5.2 ebuild, so I'm sorry this is not a patch. I also did not (yet) have time to test the new program mupmate (which requires fltk).
I've added mup-5.4 to Portage.. closing.
