Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 120250 - media-gfx/fbida ( and media-gfx/fbi ) have missing ghostscript DEPEND
Summary: media-gfx/fbida ( and media-gfx/fbi ) have missing ghostscript DEPEND
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: High enhancement (vote)
Assignee: Michal Januszewski (RETIRED)
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2006-01-24 18:58 UTC by richard juckes
Modified: 2006-01-29 13:40 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---

Attachments
patch to fbiida-2.03-r1.ebuild (fbida-2.03-r1.ebuild.patch,1021 bytes, patch)
2006-01-24 19:00 UTC, richard juckes 		Details | Diff
the right patch (fbida-2.03-r1.ebuild.patch,1019 bytes, patch)
2006-01-24 19:24 UTC, richard juckes 		Details | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description richard juckes 2006-01-24 18:58:48 UTC 
fbida has a script called fbgv which converts pdfs to a temporary tiff file using ghostscript, and then calls fbi to view them.
The attached patch to fbida-2.03-r1.ebuild adds a pdf USE flag, a ?pdf DEPEND for ghostscript-eps, and a check that the tiff USE flag is set.
Comment 1 richard juckes 2006-01-24 19:00:08 UTC 
Created attachment 78041 [details, diff]
patch to fbiida-2.03-r1.ebuild
Comment 2 richard juckes 2006-01-24 19:24:08 UTC 
Created attachment 78043 [details, diff]
the right patch

doh! this one is better
Comment 3 Jakub Moc (RETIRED) gentoo-dev 2006-01-25 00:45:49 UTC 
The patch is wrong.

1/ should depend on virtual/ghostscript instead 
2  pdf use flag should include media-libs/tiff dependency if tiff use flag is not set, instead of pointless bailing out later on in the ebuild.
Comment 4 Michal Januszewski (RETIRED) gentoo-dev 2006-01-29 13:40:16 UTC 
Fixed in CVS. Thanks for your patches and suggestions. I chose to ignore media-gfx/fbi, since this package is deprecated and will be removed soon. Adding proper support for all USE flags would require rewriting half the ebuild.