Bugzilla Bug 119942

emerge abiword-plugins fail when poppler is 0.5.0 and the pdf use flag is set
(see #119919). This will be fixed upstream (I'll fix) by disabling the pdf when
poppler is installed without the xpdf headers, but this is an important feature
loss.

 x86_64-pc-linux-gnu-g++ -DPACKAGE_NAME=\"abiword-plugins\"
-DPACKAGE_TARNAME=\"abiword-plugins\" -DPACKAGE_VERSION=\"2.4.1\"
"-DPACKAGE_STRING=\"abiword-plugins 2.4.1\""
-DPACKAGE_BUGREPORT=\"http://bugzilla.abisource.com/\" -DSTDC_HEADERS=1
-DHAVE_SYS_TYPES_H=1 -DHAVE_SYS_STAT_H=1 -DHAVE_STDLIB_H=1 -DHAVE_STRING_H=1
-DHAVE_MEMORY_H=1 -DHAVE_STRINGS_H=1 -DHAVE_INTTYPES_H=1 -DHAVE_STDINT_H=1
-DHAVE_UNISTD_H=1 -DHAVE_STRINGS_H=1 -DPACKAGE=\"abiword\" -DVERSION=\"2.4.1\"
-DHAVE_DLFCN_H=1 -DHAVE_SYS_WAIT_H=1 -DHAVE_UNISTD_H=1 -DHAVE_LIBBZ2=1
-DTIME_WITH_SYS_TIME=1 -I. -I. -DNDEBUG
-I/var/tmp/portage/abiword-plugins-2.4.1-r2/work/abiword-2.4.1/abi/src/af/util/xp
-I/var/tmp/portage/abiword-plugins-2.4.1-r2/work/abiword-2.4.1/abi/src/af/util/unix
-I/var/tmp/portage/abiword-plugins-2.4.1-r2/work/abiword-2.4.1/abi/src/af/xap/xp
-I/var/tmp/portage/abiword-plugins-2.4.1-r2/work/abiword-2.4.1/abi/src/af/ev/xp
-I/var/tmp/portage/abiword-plugins-2.4.1-r2/work/abiword-2.4.1/abi/src/af/gr/xp
-I/var/tmp/portage/abiword-plugins-2.4.1-r2/work/abiword-2.4.1/abi/src/text/fmt/xp
-I/var/tmp/portage/abiword-plugins-2.4.1-r2/work/abiword-2.4.1/abi/src/text/ptbl/xp
-I/var/tmp/portage/abiword-plugins-2.4.1-r2/work/abiword-2.4.1/abi/src/wp/impexp/xp
-I/var/tmp/portage/abiword-plugins-2.4.1-r2/work/abiword-2.4.1/abi/src/wp/ap/xp
-I/var/tmp/portage/abiword-plugins-2.4.1-r2/work/abiword-2.4.1/abi/src/other/spell/xp
-I/var/tmp/portage/abiword-plugins-2.4.1-r2/work/abiword-2.4.1/abi/src/other/fribidi/xp
-I/var/tmp/portage/abiword-plugins-2.4.1-r2/work/abiword-2.4.1/abi/src/other/ttftool/unix
-I/var/tmp/portage/abiword-plugins-2.4.1-r2/work/abiword-2.4.1/abi/src/af/xap/unix
-I/var/tmp/portage/abiword-plugins-2.4.1-r2/work/abiword-2.4.1/abi/src/af/ev/unix
-I/var/tmp/portage/abiword-plugins-2.4.1-r2/work/abiword-2.4.1/abi/src/af/gr/unix
-I/var/tmp/portage/abiword-plugins-2.4.1-r2/work/abiword-2.4.1/abi/src/wp/ap/unix
-DABI_PLUGIN_VERSION=\"2.4.1\" -DABI_PLUGIN_MAJOR=2 -DABI_PLUGIN_MINOR=4
-DABI_PLUGIN_MICRO=1 -DABI_PLUGIN_SOURCE=1 -I/usr/local/include/fribidi
-I/usr/include/freetype2 -I/usr/include/freetype2/config
-I/usr/include/glib-2.0 -I/usr/lib64/glib-2.0/include -I/usr/include/gtk-2.0
-I/usr/lib64/gtk-2.0/include -I/usr/include/atk-1.0 -I/usr/include/cairo
-I/usr/include/pango-1.0 -I/usr/include/libglade-2.0 -I/usr/include/libxml2
-I/usr/include/poppler -march=athlon64 -g -O2 -pipe -MT
ie_imp_PDF.lo -MD -MP -MF .deps/ie_imp_PDF.Tpo -c ie_imp_PDF.cpp  -fPIC -DPIC
-o .libs/ie_imp_PDF.o
ie_imp_PDF.cpp:31:26: GlobalParams.h: No such file or directory
ie_imp_PDF.cpp:32:20: Object.h: No such file or directory
ie_imp_PDF.cpp:33:20: Stream.h: No such file or directory
ie_imp_PDF.cpp:34:19: Array.h: No such file or directory
ie_imp_PDF.cpp:35:18: Dict.h: No such file or directory
ie_imp_PDF.cpp:36:18: XRef.h: No such file or directory
ie_imp_PDF.cpp:37:21: Catalog.h: No such file or directory
ie_imp_PDF.cpp:38:18: Page.h: No such file or directory
ie_imp_PDF.cpp:39:20: PDFDoc.h: No such file or directory
ie_imp_PDF.cpp:40:27: TextOutputDev.h: No such file or directory
ie_imp_PDF.cpp:41:23: CharTypes.h: No such file or directory
ie_imp_PDF.cpp:42:24: UnicodeMap.h: No such file or directory
ie_imp_PDF.cpp:43:19: Error.h: No such file or directory
...

emerge --info:
Portage 2.1_pre3-r1 (default-linux/amd64/2005.1/no-multilib, gcc-3.4.5,
glibc-2.3.6-r2, 2.6.14-gentoo-r2 x86_64)
=================================================================
System uname: 2.6.14-gentoo-r2 x86_64 AMD Athlon(tm) 64 Processor 3000+
Gentoo Base System version 1.12.0_pre15
distcc 2.18.3 x86_64-pc-linux-gnu (protocols 1 and 2) (default port 3632)
[disabled]
dev-lang/python:     2.3.5, 2.4.2
sys-apps/sandbox:    1.2.17
sys-devel/autoconf:  2.13, 2.59-r7
sys-devel/automake:  1.4_p6, 1.5, 1.6.3, 1.7.9-r1, 1.8.5-r3, 1.9.6-r1
sys-devel/binutils:  2.16.1-r1
sys-devel/libtool:   1.5.22
virtual/os-headers:  2.6.11-r3
ACCEPT_KEYWORDS="amd64 ~amd64"
AUTOCLEAN="yes"
CBUILD="x86_64-pc-linux-gnu"
CFLAGS="-march=athlon64 -g -O2 -pipe"
CHOST="x86_64-pc-linux-gnu"
CONFIG_PROTECT="/etc /usr/kde/2/share/config /usr/kde/3/share/config
/usr/lib/X11/xkb /usr/share/config /var/qmail/control"
CONFIG_PROTECT_MASK="/etc/gconf /etc/terminfo /etc/texmf/web2c /etc/env.d"
CXXFLAGS="-march=athlon64 -g -O2 -pipe"
DISTDIR="/usr/portage/distfiles"
FEATURES="autoconfig distlocks sandbox sfperms strict"
GENTOO_MIRRORS="ftp://ftp-stud.fht-esslingen.de/pub/Mirrors/gentoo/
http://gentoo.oregonstate.edu/
http://www.ibiblio.org/pub/Linux/distributions/gentoo/"
LANG="fr_FR.UTF-8"
LC_ALL="fr_FR.UTF-8"
LINGUAS="de es fr it pl ru zh_CN"
MAKEOPTS=""
PKGDIR="/usr/portage/packages"
PORTAGE_TMPDIR="/var/tmp"
PORTDIR="/usr/portage"
SYNC="rsync://rsync.europe.gentoo.org/gentoo-portage"
USE="amd64 X alsa audiofile avi berkdb bitmap-fonts bonobo bzip2 bzlib cdr
crypt cups curl dba dvd dvdr eds emboss encode esd exif expat fam firefox
foomaticdb fortran ftp gd gdbm gif glut gmp gnome gpm gstreamer gtk gtk2
gtkhtml guile hal idn imagemagick imlib ipv6 java javascript jpeg junit lcms
ldap libwww lzw lzw-tiff mad mng motif mp3 mpeg ncurses nls opengl pam pcre pdf
pdflib perl png postgres print python quicktime readline ruby samba scanner sdl
spell ssl tcltk tcpd tetex tiff truetype truetype-fonts type1-fonts udev usb
userlocales xml2 xpm xv yaz zlib elibc_glibc kernel_linux linguas_de linguas_es
linguas_fr linguas_it linguas_pl linguas_ru linguas_zh_CN userland_GNU"
Unset:  ASFLAGS, CTARGET, LDFLAGS, PORTDIR_OVERLAY

Created an attachment (id=77831) [edit]
abiword-plugins need poppler<0.5.0

Hmm, the situation is worse than I thought. Even if I install the missing
headers, things do not work because abiword-plugins-2.4.x are not compatible
with poppler 0.5.0 (configure should test that and will do, hopefully, in
0.4.3, if released one day...).
We just cannot build the pdf plugin.

Created an attachment (id=77836) [edit]
previous patch broke evince

Just use --without-pdf :-(

abiword-plugins-2.4.2 seems to assume the tetex version of xpdf (or wherever
those headers are supposed to come from).  USE='-pdf' is really not a good
solution (there is a reason we want the pdf plugin). 

0.4.2 does not compile for me either, same problem. I have tetex installed, but
the xpdf headers are not there.
make can find them only if they are in /usr/include or /usr/include/poppler
when building the pdf plugin.
I agree that the pdf plugin should be built, it just fails for me, and I see no
solution for that. emerging either tetex or xpdf do not install the xpdf
headers.

Actually, the pdf plugin will not build with the xpdf headers from any of
these:
1. app-text/xpdf-3.01-r6
2. app-text/poppler-0.5.0
3. app-text/tetex-3.0_p1-r1
A reasonable approach would be to require poppler install all its header files
into /usr/include/poppler and /usr/include/poppler/goo and to update the
abiword pdf plugin to build with these headers.  If you make no changes to the
plugin, the build fails with things like:

ie_imp_PDF.cpp: In member function `virtual UT_Error
IE_Imp_PDF::importFile(const char*)':
ie_imp_PDF.cpp:78: error: no matching function for call to
`PDFDoc::displayPages(TextOutputDev*&, int, int, int, int, int, int, int)'
/usr/include/xpdf/PDFDoc.h:104: note: candidates are: void
PDFDoc::displayPages(OutputDev*, int, int, double, double, int, GBool, GBool,
GBool, GBool (*)(void*), void*, GBool (*)(Annot*, void*), void*)

So it looks like abiword-plugins pdf plugin depends on a version of xpdf and
friends which are either gone or not here yet.

poppler-0.5.0 is a development version, stable is 0.4.4. Abiword-2.4.x is
stable and cannot use a development version of anything, and the pdf plugin
compiles fine with poppler-0.4.4. cvs HEAD uses poppler-0.5.0.

The last comment is correct. I don't think the development version of popler
should have been added to the tree and this is exactly the reason why
development versions of libs aren't normally added. Hard deping on a lower
version will cause some nasty upgrade/downgrade issues for people who insist on
using -D. I'll see if it is possible to backport a patch from abiword cvs head.

Okay, so there are two problems, the first is the poppler API change:

This is upstream here: http://bugzilla.abisource.com/show_bug.cgi?id=9905

The API fix is simple:

diff -ur xp/ie_imp_PDF.cpp
/home/obz/Gentoo/cvs/abiword-plugins/wp/impexp/pdf/xp/ie_imp_PDF.cpp
--- xp/ie_imp_PDF.cpp   2005-06-29 10:22:13.000000000 +0800
+++ /home/obz/Gentoo/cvs/abiword-plugins/wp/impexp/pdf/xp/ie_imp_PDF.cpp       
2006-01-22 09:24:52.000000000 +0800
@@ -75,7 +75,7 @@
       UT_tmpnam(temporary_file);

       TextOutputDev *textOut = new TextOutputDev(temporary_file, gFalse,
gFalse, gFalse);
-      doc->displayPages(textOut, 1, doc->getNumPages(), 72, 72, 0, gTrue,
gFalse);
+      doc->displayPages(textOut, 1, doc->getNumPages(), 72, 72, 0, gTrue,
gFalse, gFalse);
       delete textOut;

       IE_Imp_Text txt_imp(getDoc(), "UTF-8");


But secondly, and the real problem for us (on Gentoo), is that because poppler
won't provide the xpdf headers, see bug:
http://bugs.gentoo.org/show_bug.cgi?id=11 the pdf plugin will be disabled,
which I think is a pretty serious feature loss.

I've reopened http://bugs.gentoo.org/show_bug.cgi?id=119919 because that's
where the problem lies and should be fixed.

Apologies, http://bugs.gentoo.org/show_bug.cgi?id=11 should be 
http://bugs.gentoo.org/show_bug.cgi?id=119919

Patch verified.  If you install the poppler-0.5.0 header files into
/usr/include/poppler and apply the patch from Comment #8, then abiword-plugins
builds with USE=pdf, and abiword can convert MS .doc files into .pdf files
which xpdf can work with. Also abiword can read (some) .pdf files.  Curiously,
for me, at least, the .pdf files which abiword writes can be read by xpdf but
not by abiword itself(?).

Here's the patch:
http://www.abisource.com/viewcvs/cgi/viewcvs.cgi/abiword-plugins/wp/impexp/pdf/xp/ie_imp_PDF.cpp.diff?r2=1.3&r1=1.2&diff_format=u

Thanks Ed, that's exactly my patch in comment #8, but for the real problem see
the bug that this one depends on.

(In reply to comment #12)
> Thanks Ed, that's exactly my patch in comment #8, but for the real problem see
> the bug that this one depends on.
> 

The bug it depends on is solved, xpdf-headers are installed. I could get a
usable abiword-pdf-plugin (im- and export) using the plugins patch you
mentioned in comment #8 and comment #11 So is there any chance to get this in
the tree?

*** Bug 122733 has been marked as a duplicate of this bug. ***

Fixed in cvs, sync in a few hours. Sorry for the wait on this and thanks to
anybody working on it.