First Last Prev Next    No search results available      Search page      Enter new bug
Bug#: 119532
Alias:
Product:
Component:
Status: RESOLVED
Resolution: FIXED
Assigned To: Stefan Schweizer <genstef@gentoo.org>
Hardware:
OS:
Version:
Priority:
Severity:
Reporter: Patrizio Bassi <hetfield666@gmail.com>
Add CC:
CC:
Remove selected CCs
URL:
Summary:
Status Whiteboard:
Keywords:

Filename Description Type Creator Created Size Actions
Create a New Attachment (proposed patch, testcase, etc.) View All

Bug 119532 depends on: Show dependency tree
Bug 119532 blocks:
Votes: 0    Show votes for this bug    Vote for this bug

Additional Comments: (this is where you put emerge --info)


Not eligible to see or edit group visibility for this bug.






View Bug Activity   |   Format For Printing   |   XML   |   Clone This Bug


Description:   Opened: 2006-01-19 04:52 0000
2.6.16 changed some api..as usual :)

fix is from Miklos  Szeredi (fuse mainteiner) and will be merged in 2.5.1

Index: kernel/file.c
===================================================================
RCS file: /cvsroot/fuse/fuse/kernel/file.c,v
retrieving revision 1.94
retrieving revision 1.94.2.1
diff -u -r1.94 -r1.94.2.1
--- kernel/file.c       6 Jan 2006 18:29:39 -0000       1.94
+++ kernel/file.c       18 Jan 2006 12:17:33 -0000      1.94.2.1
@@ -675,9 +675,15 @@
        struct inode *inode = file->f_dentry->d_inode;
        ssize_t res;
        /* Don't allow parallel writes to the same file */
+#ifdef KERNEL_2_6_16_PLUS
+       mutex_lock(&inode->i_mutex);
+       res = fuse_direct_io(file, buf, count, ppos, 1);
+       mutex_unlock(&inode->i_mutex);
+#else
        down(&inode->i_sem);
        res = fuse_direct_io(file, buf, count, ppos, 1);
        up(&inode->i_sem);
+#endif
        return res;
 }

Index: kernel/fuse_i.h
===================================================================
RCS file: /cvsroot/fuse/fuse/kernel/fuse_i.h,v
retrieving revision 1.99
retrieving revision 1.99.2.1
diff -u -r1.99 -r1.99.2.1
--- kernel/fuse_i.h     14 Jan 2006 14:47:21 -0000      1.99
+++ kernel/fuse_i.h     18 Jan 2006 12:17:33 -0000      1.99.2.1
@@ -40,6 +40,9 @@
 #  if LINUX_VERSION_CODE >= KERNEL_VERSION(2,6,13)
 #    define KERNEL_2_6_13_PLUS
 #  endif
+#  if LINUX_VERSION_CODE >= KERNEL_VERSION(2,6,16)
+#    define KERNEL_2_6_16_PLUS
+#  endif
 #endif

 #include "config.h"


please apply asap

------- Comment #1 From Jakub Moc (RETIRED) 2006-01-19 04:57:57 0000 -------
*** Bug 119533 has been marked as a duplicate of this bug. ***

------- Comment #2 From Jakub Moc (RETIRED) 2006-01-19 04:58:07 0000 -------
*** Bug 119534 has been marked as a duplicate of this bug. ***

------- Comment #3 From Patrizio Bassi 2006-01-19 05:28:45 0000 -------
i'm sorry for bugzilla spam, server had some problems and it always timed out.

------- Comment #4 From Jakub Moc (RETIRED) 2006-01-19 16:19:33 0000 -------
*** Bug 119617 has been marked as a duplicate of this bug. ***

------- Comment #5 From Stefan Schweizer 2006-01-20 02:48:21 0000 -------
can you please attach a real patch file that works?
first hunk fails for me:


PATCH COMMAND:  patch -p0 -g0 --no-backup-if-mismatch <
/usr/portage/sys-fs/fuse/files/fuse-2.6.16.patch

=============================
patching file kernel/file.c
Hunk #1 FAILED at 675.
1 out of 1 hunk FAILED -- saving rejects to file kernel/file.c.rej
patching file kernel/fuse_i.h
=============================

------- Comment #6 From Patrizio Bassi 2006-01-20 02:55:01 0000 -------
That's the cvs commit Miklos sent to me.
have u stripped cvs formatting things?
if so, it should depends on white spaces/tabs.

i did manual patching, so didn't use patch tool.

------- Comment #7 From Stefan Schweizer 2006-01-20 04:51:24 0000 -------
*** Bug 119676 has been marked as a duplicate of this bug. ***

------- Comment #8 From Stefan Schweizer 2006-01-20 12:20:51 0000 -------
got it working, thanks.

Please attach patches next time to avoid such issues :)

------- Comment #9 From Jakub Moc (RETIRED) 2006-04-23 15:25:21 0000 -------
*** Bug 131036 has been marked as a duplicate of this bug. ***

First Last Prev Next    No search results available      Search page      Enter new bug