Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 118542 - catalyst-2.0_rc13: 'livecd/linuxrc' setting is being ignored
Summary: catalyst-2.0_rc13: 'livecd/linuxrc' setting is being ignored
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Hosted Projects
Classification: Unclassified
Component: Catalyst (show other bugs)
Hardware: All Linux
: High normal (vote)
Assignee: Gentoo Catalyst Developers
URL:
Whiteboard:
Keywords: InVCS
Depends on:
Blocks:
 
Reported: 2006-01-10 09:10 UTC by Bardur Arantsson
Modified: 2006-01-13 07:00 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments
patch to handle 'livecd/linuxrc' properly (catalyst-linuxrc.patch,2.48 KB, patch)
2006-01-10 09:37 UTC, Bardur Arantsson
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Bardur Arantsson 2006-01-10 09:10:31 UTC
It seems that several of the catlyst2 scripts are using ${clst_linuxrc} when they should be using ${clst_livecd_linuxrc} -- thus causing the 'livecd/linuxrc' stage2 spec file option to be ignored. The patch which will be attached shortly should fix that.
Comment 1 Bardur Arantsson 2006-01-10 09:37:45 UTC
Created attachment 76756 [details, diff]
patch to handle 'livecd/linuxrc' properly
Comment 2 Bardur Arantsson 2006-01-10 09:41:46 UTC
Writing the patch I noticed that the 'embedded' and 'stage4' targets don't seem to actually enable one to specify a corresponding <bla>/linuxrc option, so I think that maybe the affected code should just be removed from those *-controller.sh scripts instead. (Not having used those targets at all I'm not sure how much sense a 'linuxrc' option makes for those anyway...)
Comment 3 Chris Gianelloni (RETIRED) gentoo-dev 2006-01-10 11:23:39 UTC
It is supposed to be clst_linuxrc, not clst_livecd_linuxrc, which means the python needs to be changed, not the bash.  Also, both embedded and stage4 should have the option.
Comment 4 Chris Gianelloni (RETIRED) gentoo-dev 2006-01-10 11:24:44 UTC
Forgot to accept...
Comment 5 Chris Gianelloni (RETIRED) gentoo-dev 2006-01-10 11:53:46 UTC
This will be fixed in _rc14 comes around...
Comment 6 Bardur Arantsson 2006-01-10 12:21:55 UTC
Ok, I wasn't sure which of the two possibilities was the 'correct' one, so I just picked what I though would be the easier one ;)

Thanks,
Comment 7 Chris Gianelloni (RETIRED) gentoo-dev 2006-01-13 07:00:22 UTC
rc14 is in the tree now...