Bugzilla Bug 117528

I just spent my evening writing an ebuild for this app before realizing it was
in portage. The ebuild might be able to be improved.

1. There is a libpcap virtual which could be used. I can't test it though, I
found--can't create _any_ sockets on my web server :(.

2. The package is called pingtunnel but the binary and man page are called
ptunnel. There are some other apps out there (but I don't think in portage)
that go by the name of ptunnel so probably pingtunnel is better.

3. There is some html documentation that isn't installed.

4. Lastly, I don't know if this is really an important style thing or not, but
in the patch I used the $MY_P and $MY_PN instead of static strings.

Created an attachment (id=76035) [details]
proposed patch

(In reply to comment #0)
> 1. There is a libpcap virtual which could be used. I can't test it though, I
> found--can't create _any_ sockets on my web server :(.

the net-libs/libpcap-ringbuffer package is broken and it shouldn't provide
virtual/libpcap (see bug #117898)

> 2. The package is called pingtunnel but the binary and man page are called
> ptunnel. There are some other apps out there (but I don't think in portage)
> that go by the name of ptunnel so probably pingtunnel is better.

unless there is a conflict, I prefer to stick with whatever names were chosed
by upstream. It would mean more than a simple file rename.

> 3. There is some html documentation that isn't installed.

added depending on "doc" useflag.

> 4. Lastly, I don't know if this is really an important style thing or not, but
> in the patch I used the $MY_P and $MY_PN instead of static strings.

I prefer the other way. It is more readable and I doubt "PingTunnel" will be
ever changed by upstream.

I've commited 3) along with a minor modification in Makefile sed, but I didn't
bump the revision. The doc useflag is the only change worth reemerging for and
"emerge -uDN world" will do that anyway.