Bugzilla Bug 117397

A new version of aMule is out and it brings a lot of new features, including
Kad support. Here is the complete changelog:
http://www.amule.org/wiki/index.php/Changelog_2.1.0

  Working great with 2.0.3 ebuild on AMD64!

Created an attachment (id=75986) [edit]
2.0.3-r4 to 2.1.0 ebuild patch

Patch against 2.0.3-r4 ebuild enabling kademila compiling and a 'kad' USE flag.

There is no --enable-kad-compile configure flag. Kad is always compiled, but
can be disabled in the preferences. ;)

Sorry, it was used in the 2.1.0-pre versions (CVS snapshots) for which I
modified the ebuild. My fault!

(In reply to comment #0)
> A new version of aMule is out and it brings a lot of new features, including
> Kad support. Here is the complete changelog:
> http://www.amule.org/wiki/index.php/Changelog_2.1.0
> 

Bumping the ebuild worked for me.

2.1.0 should be marked stable as soon as possible since it includes some very
important bugfixes (the memory leak with wxwidgets < 2.6.2 for example) and
support for Kad!

Created an attachment (id=76002) [edit]
2.1.0 ebuild

This ebuild should be correct and shold contains all the use flags needed.

No. ;P
The following configure flag are no longer there:
 --enable-kad-compile
 --disable-systray
 --enable-utf8-systray
 --enable-amulecmdgui
 --enable-webservergui

Also, you have "!net-p2p/amule" in the DEPENDS, and RESTRICTs set.

Cool! After downloading the 2.1.0 ebuild and fixing the issues mentioned in
comment #7, I can finaly compile amule with gcc 4.1.0-beta20051230. Thanks :)

Created an attachment (id=76061) [edit]
2.1.0 ebuild fix

Oops, Yesterday I posted the wrong ebuild, it was for the amule-cvs. This is
for amule-2.1.0. Also the old one compile always amule in debug mode (it was
for cvs). Sorry. Hope it helps.

Created an attachment (id=76096) [edit]
New ebuild. Fix the creation of the p2p user

When the use flag "amuled" is selected, i get this error at the creation of the
p2p user:

id: p2p: Questo utente non esiste
 * Adding group 'p2p' to your system ...
 *  - Groupid: next available
 * Adding user 'p2p' to your system ...
 *  - Userid: 105
 * Do not specify /bin/false yourself, use -1

So
-- enewuser p2p -1 /bin/false /home/p2p p2p
++ enewuser p2p -1 -1 /home/p2p p2p 

(In reply to comment #10)
> Created an attachment (id=76096) [edit]
> New ebuild. Fix the creation of the p2p user
> 
> When the use flag "amuled" is selected, i get this error at the creation of the
> p2p user:
> 
> id: p2p: Questo utente non esiste
>  * Adding group 'p2p' to your system ...
>  *  - Groupid: next available
>  * Adding user 'p2p' to your system ...
>  *  - Userid: 105
>  * Do not specify /bin/false yourself, use -1
> 
> So
> -- enewuser p2p -1 /bin/false /home/p2p p2p
> ++ enewuser p2p -1 -1 /home/p2p p2p 
> 


Could you please delete this unused part:
# Always use todays snapshot by default
DATE=$(date +%Y%m%d)
# Uncomment and edit this line to use a specific date
# Format is <Year><Month><Day>
# DATE=20050402


Could you as well remove the unused ${SYSTRAY} variable in the econf statement?


Could you as well use TAB for tab stop instead of SPACE?


cheers

SteveB

OK, I've tried the ebuild, and if I try and compile it without the gtk2 USE
flag, I end up with an error:
!!! set-wxconfig: Error:  Can't find normal or debug version:
!!! set-wxconfig:         /usr/lib64/wx/config/gtk-ansi-release-2.6 not found
!!! set-wxconfig:         /usr/lib64/wx/config/gtk-ansi-debug-2.6 not found
!!! You need to emerge wxGTK with wxgtk1 in your USE

--> the problem is, there is no wxgtk1 USE flag anymore for wxGTK-2.6.
I was working on my own ebuild and ended up with the same problem if you try to
use the base or base-unicode wx config.

I would suggest dropping gtk support, and support only gtk2 or no gui.

I will submit an updated ebuild soon for review.

Created an attachment (id=76118) [edit]
2.1.0.ebuild - Some clean and added TAB stop

I added TAB stop instead of spaces where required.
Cleaned some unneeded stuffs (#10)

(From update of attachment 76118 [edit])
I added TAB stop instead of spaces where required.
Cleaned some unneeded stuffs (#10)I added TAB stop instead of spaces where
required.
Cleaned some unneeded stuffs (comment #10)

I tried the ebuild which id is 76118 and these are my USE flags:

[ebuild     U ] net-p2p/amule-2.1.0 [2.0.3-r4] -X +amuled -debug -gtk2 -nls
-optimize +remote -remote-gui -stats -unicode

And got this error message:

>>> md5 src_uri ;-) aMule-2.1.0.tar.bz2
!!! set-wxconfig: Error:  Can't find normal or debug version:
!!! set-wxconfig:         /usr/lib/wx/config/gtk-ansi-release-2.6 not found
!!! set-wxconfig:         /usr/lib/wx/config/gtk-ansi-debug-2.6 not found
!!! You need to emerge wxGTK with wxgtk1 in your USE

This is for my server, so if I enable wxgtk1 I will need to install many things
I don't want like xorg-x11, gtk+-1, xterm...

This it didn't happen with older versions, :-(.

Created an attachment (id=76196) [edit]
amule-2.1.0.ebuild other version

I've done some cleanup on the ebuild, I'll try to justify my choices here, any
comments or improvements are of course welcome:

 * There seems to be an issue with wxGTK. The base, and unicode base wx config
(used like this "need-wxwidgets base" and "need-wxwidgets unicode" in the
previous amule ebuild) does not seem to be installed anymore. They seem to be
installed only when compiling wxGTK without the X USE flag. I didn't have the
time to investigate this too much, so people knowing more on this issue please
help us.
 So I've build a hack in the ebuild that will require either the gtk USE flag
(wxGTK is then supposed to be compiled with the X USE flag), or having wxGTK
compiled without the X USE flag (or you will get the error sent on comments 12
and 15)

 * I've reduced the number of USE flag. I think creating new USE flags for
(almost) no real functionality will only make portage USE flag list even
bigger. I've tried to keep the line of the previous ebuild.

 * Optimizations are always activated, unless you have the debug USE flag. (I
don't think a USE flag is worth this option)

 * I Did some code cleanup

It should work as expected in all cases. Still this wxGTK thing is bugging me.

There's also a known wxGTK 2.6.2 bug that crashes amule when you enter an
ipfilter URL when updating... It is suggested that wxGTK-cvs is used to rectify
this particular bug... So, make sure to make the requirement no greater than
wxGTK 2.6.1.

This is per Kry (one of the devs). I ran into this bug, posted it (so it's in
the hidden "testers" forum), was informed of the culprit and am passing it
on...

(In reply to comment #16)
> Created an attachment (id=76196) [edit]
> amule-2.1.0.ebuild other version
> 
> I've done some cleanup on the ebuild, I'll try to justify my choices here, any
> comments or improvements are of course welcome:
> 
>  * I've reduced the number of USE flag. I think creating new USE flags for
> (almost) no real functionality will only make portage USE flag list even
> bigger. I've tried to keep the line of the previous ebuild.
> 
>  * Optimizations are always activated, unless you have the debug USE flag. (I
> don't think a USE flag is worth this option)
> 
>  * I Did some code cleanup
> 
> It should work as expected in all cases. Still this wxGTK thing is bugging me.
> 

I think that the USE flag X is needed because, everyone who want to use
amuled/remote-gui(or amuleweb) doesn't need amule...

(In reply to comment #12)
> OK, I've tried the ebuild, and if I try and compile it without the gtk2 USE
> flag, I end up with an error:
> !!! set-wxconfig: Error:  Can't find normal or debug version:
> !!! set-wxconfig:         /usr/lib64/wx/config/gtk-ansi-release-2.6 not found
> !!! set-wxconfig:         /usr/lib64/wx/config/gtk-ansi-debug-2.6 not found
> !!! You need to emerge wxGTK with wxgtk1 in your USE
> 
> --> the problem is, there is no wxgtk1 USE flag anymore for wxGTK-2.6.
> I was working on my own ebuild and ended up with the same problem if you try to
> use the base or base-unicode wx config.
> 
> I would suggest dropping gtk support, and support only gtk2 or no gui.
> 
> I will submit an updated ebuild soon for review.
> 

I am against the support for only gtk2, because I can't compile amule with gtk2
with gcc 4.1.x on my system.

Created an attachment (id=76287) [edit]
amule-2.1.0.ebuild other version (v2)

I was saying to drop gtk1 support because I use wxGTK-2.6.2-r1 (latest amd64
stable version) where gtk2 is required.
So, OK, I've added gtk1 support, some test may be needed, but it's mainly
selecting the correct wxGTK config, which works fine (USE='X -gtk2').
I've also added back the X USE flag and gtk2 USE flag, and some eerror and
einfos. 
Also some bug fixing (like the RESTRICT var (with nomirror and nostrip) which
had nothing to do there AFAICT, and the wxGTK dependancy which is in fact
always required)

Works fine on amd64.

The lastest ebuild doesn't build amule-gui with USE -X. X flag is a little bit
confusing, maybe we use a different flag for --disable-monolithic, or just
remove --disable-amule-gui in -X conf. If you use amuled you can't run amule,
so you should be able to install amule-gui without amule.

This is being difficult! We are trying to have different things from the same
app by differente USE.

Maybe it would be nicer to have different ebuilds:

amule-2.1.0.ebuild  (minimal - just amule - or everything)
amuled-2.1.0.ebuild (the daemon and webserver)
amule-client-2.1.0.ebuild (the gui and cmd)

I don't know if this will be helpful but this is the only idea I had since I
have no skills to develop my own ebuilds:

This seems to be all the components of aMule (from INSTALL file). We could try
to organize them in some different ebuilds to make this easier and give users
more flexibility, don't you think so? Something like bind-tools, taken from
bind.

amule
amule-cmd
amule-gui
amuled
amule-webserver
amule-webservergui (I don't know what could be this)
ed2k (aMule ED2k link parser)
alc (aMuleLinkCreator GUI version)
alcc (aMuleLinkCreator console version)
cas (aMule Statistics)
wxcas (aMule GUI Statistics)

This could be an example:
  * amule-2.1.0.ebuild
      amule
      amule-cmd (if USE remote)
      amule-gui (if USE remote)
      ed2k
      alc
      alcc
      getinfo.sh, etc...
  * amule-daemon-2.1.0.ebuild
      amuled
      amule-webserver (if USE webserver)
      amule-webservergui (if USE webserver)

(In reply to comment #23)
> amule-webservergui (I don't know what could be this)

webservergui and amulecmdgui were basically those commandline tools running in
a wxDialog. They've been removed in v2.1.0, but it seems that we forgot to
remove all references to them. Whoops. ;)

(In reply to comment #21)
> The lastest ebuild doesn't build amule-gui with USE -X.

well, I've tried to keep a certain logic. amule-gui is a GUI, so no X flag
would mean no GUI support, so it won't build amule-gui indeed without this
flag. To me X flag means X support.

> X flag is a little bit
> confusing, maybe we use a different flag for --disable-monolithic, or just
> remove --disable-amule-gui in -X conf. If you use amuled you can't run amule,
> so you should be able to install amule-gui without amule.

the current ebuild (amule-2.1.0.ebuild other version (v2)) builds amule
'monolithic' if X is asked (gui support).
I wonder if having both amule 'monolithic' and amuled installed is a real
problem, both can work on the same system apparently (_of course_ not at the
same time).

I don't think it's really worth splitting the ebuild as that asks for more work
all in all. Well I'm no maintainer of amule, so maybe he would have something
to say about it.

right now, what you can do with the ebuild I posted is (it's all written in it,
and it informs you of what you can do when you fail choosing a correct set of
USE flags):
 * the unicode flag can be added in any of the following USE flag sets,
providing that you have the according support built with your wxGTK (on a
coherent system, this shouldn't be a problem)
 * if you want console apps only (probably because you don't have X installed):
make sure you have compiled wxGTK without the X USE flag, then compile amule
with USE='-gtk2 -X', it will NOT compile amule-gui, monolithic app, wxcas and
alc, because they need X support.
 * if you want gtk1: use -gtk2 and X USE flags (here is the only trick).
 * if you want gtk2: use gtk2 and X USE flag

For the console version:
remote => webserver
amuled => amule-daemon
stats  => cas, alcc

For the gtk1 or gtk2 versions:
remote => webserver, amule-gui
amuled => amule-daemon
stats  => cas, alcc, wxcas, alc

Hope that helps, for the exact details: read the source :)

(In reply to comment #24)
> (In reply to comment #23)
> > amule-webservergui (I don't know what could be this)
> 
> webservergui and amulecmdgui were basically those commandline tools running in
> a wxDialog. They've been removed in v2.1.0, but it seems that we forgot to
> remove all references to them. Whoops. ;)

:) It was apparently still in the beta, but not in the release I think. Well I
didn't see trace of them when building the ebuild I've posted :o)

Bumped in portage, used last version of ebuild. I've removed X use flag and
added gtk and gtk2. Thanks for sugestions and help.

And what is about when you want to install amuled and webserver? I enable
"amuled" and "remote" GUI, but the last one will install amule-gui 

1) use remote && myconf="${myconf}
   --enable-amule-gui"
2) `use_enable remote webserver`