116977 – poppler-0.4.3 doesn't compile against gcc-4.1

Bug 116977 - poppler-0.4.3 doesn't compile against gcc-4.1

Summary: poppler-0.4.3 doesn't compile against gcc-4.1

Status:	RESOLVED FIXED

Alias:	None

Product:	Gentoo Linux
Classification:	Unclassified
Component:	[OLD] GCC Porting (show other bugs)
Hardware:	All Linux

Importance:	High normal (vote)
Assignee:	Printing Team

URL:
Whiteboard:
Keywords:

Depends on:
Blocks:

Reported:	2005-12-28 06:39 UTC by Stéphane Gimenez
Modified:	2005-12-28 20:56 UTC (History)
CC List:	2 users (show)

See Also:
Package list:
Runtime testing required:	---

Attachments
patch for poppler-0.4.3 to compile against gcc-4.1 (poppler-0.4.3-gcc4.patch,508 bytes, patch) 2005-12-28 06:41 UTC, Stéphane Gimenez	Details \| Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Stéphane Gimenez 2005-12-28 06:39:19 UTC

hi, here comes the patch...
(can you repport this upstream ?)
thanks.

Comment 1 Stéphane Gimenez 2005-12-28 06:41:06 UTC

Created attachment 75673 [details, diff]
patch for poppler-0.4.3 to compile against gcc-4.1

Comment 2 SpanKY gentoo-dev

2005-12-28 13:25:16 UTC

normally we prefer the authors of patches to send their work upstream so they get proper credit ;)

Comment 3 Stéphane Gimenez 2005-12-28 14:49:33 UTC

Yep, that would be a shame to loose credit for such a /hard/ work ;)

I talked with upstream, and in fact my patch applies to some line inside files/poppler-0.4.3-utils.patch. Their cvs now includes pdftohtml but my problem was already fixed there. So upstream is clean.

Then the correct workaround is too append my patch to the existing files/poppler-gcc41.patch assuming it is applied after the other one (which by the way seems quite big for a portage-tree patch).

hope this helps

Comment 4 SpanKY gentoo-dev

2005-12-28 20:56:52 UTC

thanks, as long as upstream is fixed, i'm happy :)

added patch to cvs