Bugzilla Bug 114577

GIMP GREYCstoration is an amazing plugin for improving quality of noisy
pictures
(scans from magazines, bad JPEGs, etc.), based on some recent research about
image processing algorithms.

See the website here:
http://haypocalc.com/wiki/Gimp_Plugin_GREYCstoration
and examples here:
http://www.greyc.ensicaen.fr/~dtschump/greycstoration/demo.html

I will attach an ebuild for the new 0.2.0 version. It is pretty simple as you
will see.

Thanks, 
TGL.

Reproducible: Always
Steps to Reproduce:

Created an attachment (id=74120) [edit]
gimp-greycstoration-0.2.0.ebuild

allanonjl, i CC you since you may be interested as the gimp maintainer.

if "work" on amd64 so you could add "~amd64" to the keywords list.

Installed fine but didn't work for me. :(

What do you mean by "does not work"? 
 - it doesn't install "/usr/lib/gimp/2.0/plug-ins/greycstoration"?
 - it doesn't show up in the Filter->Misc menu?
 - the plugin dialog doesn't pop when you select it in the menu?
 - the dialog showup but the plugin doesn't do what it is supposed to?
 - something else?

Also, what is your arch, and gimp version?

Thanks.

Sorry, it works now. I just used wrong parametrs to the algorithm.
I think i need to read more before i post.

Created an attachment (id=81270) [edit]
greycstoration 1.1.1 ebuild (first try)

its nice to have a gimp greycstoration plugin ebuild, but what about the
"original" greycstoration? a bit before you posted this ebuild i wrote a q'n'd
ebuild for greycstoration, but missed to post it.

so - here it is :P

(In reply to comment #7)
> its nice to have a gimp greycstoration plugin ebuild, but what about the
> "original" greycstoration? a bit before you posted this ebuild i wrote a q'n'd
> ebuild for greycstoration, but missed to post it.
> 
> so - here it is :P
> 

I think you should open a new bug for this one. It would be a different
package, maybe with a different maintainer, so there is no reason to have both
in the same report.

Also, some comments about your ebuild:
 - description is too long i think:
http://dev.gentoo.org/~ciaranm/docs/mw-faq/toolong.txt
 - src_unpack() is redundant:
http://dev.gentoo.org/~ciaranm/docs/mw-faq/redundant.txt
 - hardcoded versions ("CImg-1-11") in SRC_URI are bad:
http://dev.gentoo.org/~ciaranm/docs/mw-faq/hardcoded.txt
(you can use versionator.eclass to turn "1.1.1" into "1-11")
 - same for ${S}, it should be something like
"S=${WORKDIR}/CImg-${MY_PV}/examples", which would also avoid the "cd
examples/" in src_*()
 - need a DEPEND on "app-arch/unzip" for unpacking

any guesses as to when this will become part of the portage tree?  (i'm
curious, not impatient).

Created an attachment (id=115058) [edit]
media-gfx/greycstoration-2.5.2.1

This ebuild uses the 2.5.2.1 version of GREYCstoration (see
http://www.greyc.ensicaen.fr/~dtschump/greycstoration/ ), which comes with the
gimp plugin.
It's using a custom Makefile to allow USEs (X png jpeg tiff imagemagick fftw
gimp).
It's working well for me with:
x11-libs/libX11-1.0.3
x11-libs/libXrandr-1.1.1
x11-libs/libXext-1.0.1
media-libs/libpng-1.2.15
media-libs/jpeg-6b-r7
media-libs/tiff-3.8.2-r2
media-gfx/imagemagick-6.3.0.5
sci-libs/fftw-3.0.1-r2
media-gfx/gimp-2.2.12

Created an attachment (id=115059) [edit]
Makefile-2.5.2.1

Custom makefile to use with attachment #115058 [edit]

I have just committed media-plugins/gimp-greycstoration to the tree. I believe
it's best to have two different packages. I will work on the command-line tool,
but you'll have to be patient as it's a big mess to clean up.

(In reply to comment #10)
> This ebuild uses the 2.5.2.1 version of GREYCstoration (see
> http://www.greyc.ensicaen.fr/~dtschump/greycstoration/ ), which comes with the
> gimp plugin.
> It's using a custom Makefile to allow USEs (X png jpeg tiff imagemagick fftw
> gimp).

Your work is very interesting, and your ebuild isn't badly written at all.
However, I think it will be a lot easier and cleaner to not use any Makefile.
Something similar to what I did in the gimp plugin, and passing options to the
compilation command as arguments. I have a semi-working version of this already
in my local overlay.

I'm leaving this open until I commit the command-line version to the tree

Denis.

(In reply to comment #12)
> I'm leaving this open until I commit the command-line version to the tree

All done, thanks to everybody.

Denis.

So why is this ebuild called -1.2.7 when the current version about 2.8!? Is
this for cimg?

You are sure you reflect a current version?

(In reply to comment #14)
> So why is this ebuild called -1.2.7 when the current version about 2.8!? Is
> this for cimg?
> 
> You are sure you reflect a current version?

Yes this was recent. Development of CImg and GREYCstoration occur in parallel.
Actually the latter is coding example for the former. At first sight I thought
that CImg was updated more frequently. This could still be the case, but
GREYCstoration was just updated with major new features, so I switched. Let's
hope it doesn't change in the future because it's not going to be easy to
revert this.

Anyway, the new version of both the standalone application and the gimp plugin
are now in the tree. And I patched the plugin to support
multicore/multiprocessor out of the box. Yay !

Denis.

Please add app-arch/unzip to RDEPEND.

(In reply to comment #16)
> Please add app-arch/unzip to RDEPEND.

Fixed, thanks.

Denis.