Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 114156 - genkernel didn't correctly handle "--no-color" option
Summary: genkernel didn't correctly handle "--no-color" option
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Hosted Projects
Classification: Unclassified
Component: genkernel (show other bugs)
Hardware: All Linux
: High trivial (vote)
Assignee: Gentoo Genkernel Maintainers
URL:
Whiteboard:
Keywords: InVCS
Depends on:
Blocks:
 
Reported: 2005-12-01 08:43 UTC by Evgeniy Dushistov
Modified: 2007-02-14 21:56 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments
Fix --color and --no-color (genkernel-3.3.11d_fix-no-colors.patch,1.17 KB, patch)
2006-07-10 06:04 UTC, Martin Parm
Details | Diff
Fix --color and --no-color (genkernel-3.4.0_pre2 patch) (genkernel-3.4.0_pre2_fix-no-colors.patch,1.19 KB, patch)
2006-07-10 08:13 UTC, Martin Parm
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Evgeniy Dushistov 2005-12-01 08:43:32 UTC
I start
genkernel --no-color --oldconfig --gensplash=emergence --kerneldir=./ all
but gentoo output caption: " Gentoo Linux Genkernel; Version 3.3.8" using green color,
also it used green color for "*", which it print at the begin of each line.

Reproducible: Always
Steps to Reproduce:
1.
2.
3.
Comment 1 Martin Parm 2006-07-10 05:40:58 UTC
Hmmm, a quick grep suggests that this feature was never really implemented. 

# grep -R CMD_USECOLOR *
gen_cmdline.sh:		      CMD_USECOLOR=1
gen_cmdline.sh:		      print_info 2 "CMD_USECOLOR: $CMD_USECOLOR"
gen_cmdline.sh:		      CMD_USECOLOR=0
gen_cmdline.sh:		      print_info 2 "CMD_USECOLOR: $CMD_USECOLOR"
Comment 2 Martin Parm 2006-07-10 06:04:47 UTC
Created attachment 91360 [details, diff]
Fix --color and --no-color

This patch was created with genkernel-3.3.11d.

Is seems to fix the problem, though I haven't tested every single possibility.
Comment 3 Martin Parm 2006-07-10 08:13:23 UTC
Created attachment 91368 [details, diff]
Fix --color and --no-color (genkernel-3.4.0_pre2 patch)

Same fix, different genkernel version
This patch was made with genkernel-3.4.0_pre2.
Comment 4 Chris Gianelloni (RETIRED) gentoo-dev 2007-02-08 00:07:49 UTC
I've fixed this now in subversion, so it'll show up in the next genkernel version.  Sorry it took so long to get this fixed.
Comment 5 Chris Gianelloni (RETIRED) gentoo-dev 2007-02-14 21:56:43 UTC
Fixed in 3.4.7_pre3