First Last Prev Next    No search results available      Search page      Enter new bug
Bug#: 113747
Alias:
Product:
Component:
Status: RESOLVED
Resolution: FIXED
Assigned To: Stefan Schweizer <genstef@gentoo.org>
Hardware:
OS:
Version:
Priority:
Severity:
Reporter: Radek Podgorny <radek@podgorny.cz>
Add CC:
CC:
Remove selected CCs
URL:
Summary:
Status Whiteboard:
Keywords:

Filename Description Type Creator Created Size Actions
fuse-2.4.1.patch fuse-2.4.1.patch patch Peter Hyman 2005-12-03 15:33 0000 568 bytes Details | Diff
fuse-2.4.2.patch fuse-2.4.2.patch patch Peter Hyman 2005-12-03 15:34 0000 574 bytes Details | Diff
Create a New Attachment (proposed patch, testcase, etc.) View All

Bug 113747 depends on: Show dependency tree
Bug 113747 blocks:
Votes: 0    Show votes for this bug    Vote for this bug

Additional Comments: (this is where you put emerge --info)


Not eligible to see or edit group visibility for this bug.






View Bug Activity   |   Format For Printing   |   XML   |   Clone This Bug


Description:   Opened: 2005-11-27 14:30 0000
...as it fixes some security bugs.

Thanks...

------- Comment #1 From Jakub Moc (RETIRED) 2005-11-27 14:38:04 0000 -------
This is already fixed in 2.4.1-r1 (Bug 112902)

------- Comment #2 From Peter Hyman 2005-12-03 15:06:31 0000 -------
You may wish to include this patch which fixes a bad memory leak then. And
2.4.2
IS a new release not included in 2.4.1-r1.

From fuse-devel newsgroup by author, Miklos Szeredi

Index: lib/fuse.c
===================================================================
RCS file: /cvsroot/fuse/fuse/lib/fuse.c,v
retrieving revision 1.148
diff -u -r1.148 fuse.c
--- lib/fuse.c  28 Nov 2005 16:02:27 -0000      1.148
+++ lib/fuse.c  2 Dec 2005 11:00:31 -0000
@@ -1742,6 +1742,7 @@
 void fuse_process_cmd(struct fuse *f, struct fuse_cmd *cmd)
 {
     fuse_session_process(f->se, cmd->buf, cmd->buflen, cmd->ch);
+    free_cmd(cmd);
 }

 int fuse_exited(struct fuse *f)
@@ -1779,6 +1780,8 @@
         int res = fuse_chan_receive(ch, cmd->buf, bufsize);
         if (res <= 0) {
             free_cmd(cmd);
+            if (res == -1)
+                fuse_exit(f);
             return NULL;
         }
         cmd->buflen = res;

This is a bad one. Line #s against 2.4.1 are very different though. See
functions:

void fuse_process_cmd (diff begins at line 1656)
struct fuse_cmd *fuse_read_cmd (diff begins at line 1693)

I strongly recommend upgrading to 2.4.2 and modifying the above patch to repair
the leak.

------- Comment #3 From Peter Hyman 2005-12-03 15:33:31 0000 -------
Created an attachment (id=74016) [edit]
fuse-2.4.1.patch

fix memory leak

------- Comment #4 From Peter Hyman 2005-12-03 15:34:43 0000 -------
Created an attachment (id=74017) [edit]
fuse-2.4.2.patch

fix memory leak. I strongly recommend implementing 2.4.2. Lots of changes. In
addition, I also suggest having a cvs version as is done with enlightenment.
Have a version 2.4.9999 which will pull in cvs for this series on demand by
user.

------- Comment #5 From Stefan Schweizer 2005-12-03 16:08:21 0000 -------
Thanks, fixed

First Last Prev Next    No search results available      Search page      Enter new bug