Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 113634 - genkernel initrd lvmraid option is incompatible with using multiple raiddevices
Summary: genkernel initrd lvmraid option is incompatible with using multiple raiddevices
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Hosted Projects
Classification: Unclassified
Component: genkernel (show other bugs)
Hardware: All Linux
: High minor (vote)
Assignee: Gentoo Genkernel Maintainers
URL:
Whiteboard:
Keywords: InVCS
Depends on:
Blocks:
 
Reported: 2005-11-26 09:03 UTC by Fati
Modified: 2005-12-16 12:11 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Fati 2005-11-26 09:03:44 UTC
To activate the volume group with the root partition on my system, I have to
activate 2 md raid devices.  This is possible through the lvmraid parameter. 
Through the script logic it appeared as though the feature was meant to exist to
be able to specify multiple raid devices, but simply specifying lvmraid=/dev/md1
/dev/md2 was not sufficient due to the way paramater parsing is done in teh
initrd.scripts file is done.  By applying this diff inside
/usr/share/genkernel/initrd.scripts lvmraid with multiple raid devices can now
be specified with a comma delimiter as lvmraid=/dev/md1,/dev/md2

fati@eve /usr/share/genkernel $ diff generic/initrd.scripts generic/initrd.scripts~
456c447
<           for dev in `echo ${RAID_DEVICES} | sed -e 's/,/ /g'`
---
>           for dev in ${RAID_DEVICES}

Reproducible: Always
Steps to Reproduce:
1. genkernel --lvm2 --udev --gensplash=emergence initrd 
2. In lilo conf use the lvmraid paramater to specify multiple raid devices
3. Run lilo and reboot, boot will fail though the first md device you specify
will have been created.

Actual Results:  
Initrd was brought up an emergency shell where I could manually activate the
needed md devices and continue my boot.

Expected Results:  
Loaded all necessary md devices specified by the lvmraid option.

Portage 2.0.51.22-r3 (default-linux/x86/2005.1, gcc-3.3.6, glibc-2.3.5-r2,
2.6.14-gentoo-r2 i686)
=================================================================
System uname: 2.6.14-gentoo-r2 i686 Intel(R) Pentium(R) 4 CPU 3.20GHz
Gentoo Base System version 1.6.13
dev-lang/python:     2.3.5, 2.4.2
sys-apps/sandbox:    1.2.12
sys-devel/autoconf:  2.13, 2.59-r6
sys-devel/automake:  1.4_p6, 1.5, 1.6.3, 1.7.9-r1, 1.8.5-r3, 1.9.6-r1
sys-devel/binutils:  2.15.92.0.2-r10
sys-devel/libtool:   1.5.20
virtual/os-headers:  2.6.11-r2
ACCEPT_KEYWORDS="x86"
AUTOCLEAN="yes"
CBUILD="i686-pc-linux-gnu"
CFLAGS="-O2 -march=pentium4"
CHOST="i686-pc-linux-gnu"
CONFIG_PROTECT="/etc /usr/kde/2/share/config /usr/kde/3.4/env
/usr/kde/3.4/share/config /usr/kde/3.4/shutdown /usr/kde/3/share/config
/usr/lib/X11/xkb /usr/lib/mozilla/defaults/pref /usr/share/config
/var/qmail/control"
CONFIG_PROTECT_MASK="/etc/gconf /etc/terminfo /etc/env.d"
Comment 1 Tim Yamin (RETIRED) gentoo-dev 2005-11-28 07:10:55 UTC
Well right now it's lvmraid=md1 lvmraid=md2 etc... But a comma-separated system
would probably be better since everything else does it that way. Want to try
this patch instead please (undo your existing patch):

Index: linuxrc
===================================================================
RCS file: /var/cvsroot/gentoo/src/genkernel_bradmssw/generic/linuxrc,v
retrieving revision 1.85
diff -u -r1.85 linuxrc
--- linuxrc	21 Nov 2005 18:09:24 -0000	1.85
+++ linuxrc	28 Nov 2005 15:07:58 -0000
@@ -174,7 +174,8 @@
 
       # /dev/md
       lvmraid\=*)
-	  RAID_DEVICES="${RAID_DEVICES} `parse_opt ${x}`"
+	  RAID_DEVICES="`parse_opt ${x}`"
+	  RAID_DEVICES="`echo ${RAID_DEVICES} | sed -e 's/,/ /g'`"
 	  ;;
 
       part\=*)
Comment 2 Fati 2005-11-28 14:52:11 UTC
The patch you provided was successful!  Thank you!
Comment 3 Tim Yamin (RETIRED) gentoo-dev 2005-12-16 12:11:22 UTC
Fixed in 3.3.9; thanks!