Bugzilla Bug 112537

Please find attached modified ebuild and patch file for
dev-util/eclipse-sdk-3.2_pre3

Created an attachment (id=72891) [details]
eclipse-sdk-3.2_pre3.ebuild

Created an attachment (id=72892) [details]
06-path-fixups-3.2m3.patch

One more note: I have only tested the ebuild under x86 and sun-jdk.

Created an attachment (id=76315) [details]
eclipse-sdk-3.2_pre4.ebuild

Created an attachment (id=76316) [details]
06-path-fixups-3.2m4.patch

Created an attachment (id=76317) [details]
eclipse-3.2.desktop

Updated the previous M3 ebuild for eclipse 3.2 M4.  Also updated the
06-path-fixups-3.2m4.patch with fixes for x86_64.  I have successfully compiled
this ebuild on x86_64(blackdown-jdk-4.2.03) and x86(sun-jdk-1.4.2.10).

Eclipse 3.2_M5a is there... is it difficult to update the ebuild/patch ?

(In reply to comment #8)
> Eclipse 3.2_M5a is there... is it difficult to update the ebuild/patch ?
I tried to used the M4 ebuild (not tested myself) and modified it for M5. The
main difference is, that you have to supply the path to Java 5 (some module
requires it, see [1] for details). Currently, it is hardcoded in my ebuild
script, but a better way would be if java-config could be told to return the
home of the lastest Java 5 installation.
When I start to build M5, however, it stops after some time with the message,
that org.eclipse.core.runtime.IPluginDescriptor cannot be resolved. Detailed
logs can be provided upon request. But maybe someone has some better
ebuilds/patches...

[1]
http://download.eclipse.org/eclipse/downloads/drops/S-3.2M5a-200602231656/srcIncludedBuildInstructions.html

Eclipse 3.2RC1 is now available, it's time to switch over, I think.  Would some
kind soul please put together an ebuild?

I haven't had any luck getting any of the 3.2 series to build thus far.

Another set back is that some parts of eclipse need Java 1.5 to compile. And as
you may know, it is currently package.mask'd.

It seems that getting eclipse-3.2 to build will be difficult, especially since
JDK 5 support isn't really there in Gentoo yet.  Perhaps a binary install is a
good solution for now.  I tend to use the binary distributions for large
packages whenever possible (OpenOffice, FireFox, Thunderbird, etc.)

I've almost got a binary installation of Eclipse 3.2rc1 working. See
http://forums.gentoo.org/viewtopic-t-454181-highlight-.html for details - help
is appreciated.  

(In reply to comment #1)
> Created an attachment (id=72891) [edit] [details]
> eclipse-sdk-3.2_pre3.ebuild
> 

In the future, please submit diffs against the existing ebuilds. This allows
people (in particular developers) to easily see what changes you made. This is
particularly important for giant ebuilds like eclipse-sdk.

Created an attachment (id=85088) [details]
Eclipse 3.2rc1 ebuild

Eclipse 3.2rc1 ebuild. Tested only with amd64, if upstream x86/ppc builds are
as buggy then needs some more work for those architectures too.

Anyway, contains support for glx useflag, restores the cairo useflag (now cairo
>1.0 required). Requires Java 1.5 JVM (does not use at all Java 1.4 JVM when
building). Now passes gentoo CFLAGS to the native code makefiles.

Created an attachment (id=85089) [details]
old patch allowing compile of the native update.so library

Created an attachment (id=85090) [details]
Fixes for eclipse build bugs + one old sed fix converted to a Makefile patch

the last two parts of this patch might need similar adjustment on x86 and ppc

(In reply to comment #14)
Like I stated earlier(In reply to comment #14)
> Created an attachment (id=85088) [edit] [details]
> Eclipse 3.2rc1 ebuild
> 
As I requested earlier, please try to submit patches to existing ebuilds in
portage, rather than attach entire ebuilds.

You may want to be careful about what you tweak in an ebuild, especially when
it concerns architectures you can't test on. In particular, you removed a bit
in pkg_setup that would likely prevent building on x86.

The cario dependencies should be in RDEPEND, as you probably need those at
runtime.

I know you copied the bits for calling pkgconfig out of one of the scripts, but
a cleaner way of doing it is:

if pkg-config --exists firefox-xpcom ; then
   ......
elif pkg-config --exists mozilla-xpcom ; then
  ........
fi

Created an attachment (id=85785) [details]
eclipse-sdk-3.2_rc2.ebuild

Created an attachment (id=85786) [details]
3.1.2-r2 vs 3.2_rc2 ebuild

Created an attachment (id=85787) [details]
07-eclipse-3.2.patch

merged all required eclipse patches to one. The rc2 fixed most of the problems
in rc1 so the patch is now smaller and has no architecture specific parts.

Created an attachment (id=85788) [details]
eclipse-3.2 - startup wrapper

Created an attachment (id=85789) [details]
eclipse-3.1 vs eclipse-3.2 - startup wrapper

contains a fix to passing parameters that contains spaces to the real eclipse
binary

I have tested the 3.2rc2 ebuild on amd64 with both sun (5.0.06) and ibm jdk
(5.0SR1). Both compiled and ran fine. I just also noticed that the amd64
ibm-jdk 5.0 headers are now fixed and the workaround for them could be removed
from the ebuild.

Also I would like to add a comment on why I removed the 'dangerous' CFLAGS
detection: I already tried to remove it a year ago with my 3.1 ebuild when I
noticed that eclipse builds all native code with either -O0 or -O1 level and
does not respect any gentoo CFLAGS (I even added a TODO entry to the ebuild
about using gentoo cflags). Thus any problems that users might have seen
definitely were not about cflags but most likely just buggy JVM. I know that at
least the blackdown jdk has been very unstable with larger java programs.
Luckily the new ebuild requires java 5.0 which seems to be much more stable on
many platforms.

On the other hand the latest ebuild modifies the eclipse makefiles to use
gentoo CFLAGS and some new problems might pop up, but they will be totally
separate from the previous -O0 or -O1 problems and we should only add the flag
warning when we really know that some flags are dangerous.

Just a FYI: I'm using migration-overlay and java-experimental-overlay.
Yesterday I compiled eclipse-sdk-3.2_rc3 using the rc1-r1 ebuild from
java-experimental-overlay. The only change was the DATESTAMP line.

Running it right now, seems to work fine.

I just tried it with a modified (renamed and changed date) 3.2-rc2 ebuild... it
did not work.

* Failed Patch: 07-eclipse-3.2.patch !
*  ( /usr/local/portage/dev-util/eclipse-sdk/files/07-eclipse-3.2.patch )
*
* Include in your bugreport the contents of:
*
*   /var/tmp/portage/eclipse-sdk-3.2_rc3/temp/07-eclipse-3.2.patch-10343.out

I'm assuming you're talking about the ebuild from this bug, not the one from
the java-experimental overlay? Did you remember to put the 07-eclipse-3.2.patch
from this bug in
/usr/local/portage/dev-util/eclipse-sdk/files/07-eclipse-3.2.patch? What's in
/var/tmp/portage/eclipse-sdk-3.2_rc3/temp/07-eclipse-3.2.patch-10343.out?

Created an attachment (id=86787) [details]
eclipse-sdk-3.2_rc2.ebuild vs eclipse-sdk-3.2_rc4.ebuild

Created an attachment (id=86788) [details]
eclipse-sdk-3.2_rc4.ebuild

Created an attachment (id=86789) [details]
07-eclipse-3.2.patch

Created an attachment (id=86790) [details]
diff of new eclipse-3.2 startup wrapper

Created an attachment (id=86791) [details]
new eclipse-3.2 startup wrapper

Updated the ebuild for eclipse-3.2_rc4
Updated the patches for eclipse-3.2_rc4
Updated the eclipse-3.2 startup wrapper to set the MOZILLA_FIVE_HOME
environment variable

Created an attachment (id=87685) [details]
eclipse-sdk-3.2_rc5.ebuild

Created an attachment (id=87686) [details]
07-eclipse-3.2.patch

Only changes to rc5 ebuild since rc4 are:
- increased memory amount from 768M to 896M because otherwise I got OutOfMemory
when building it on one of my machines
- added a die check to make sure that liblocalfile.so is built correctly

Created an attachment (id=89787) [details]
bump to rc7

(From update of attachment 89787 [details])
bump to rc7

Not sure if you know, but new ebuilds for eclipse-sdk, with several useful
patches, are located in the java-migration-packages overlay. You first need to
start using java-migration overlay with the guide at
https://projects.gentooexperimental.org/expj/wiki/Using_migration-overlay .
This will be soon (few weeks?) in the main tree. Then you can similarly svn
checkout the java-migration-packages overlay and there are the new eclipse
ebuilds.

Added rc7 to portage. It uses the new Java system:
http://www.gentoo.org/proj/en/java/java-upgrade.xml

Note: There are only minor changes between rc7 and the official release. Will
see about using our patchset against the official release, and add it when it's
all worked out.

Also, forgot to mention that it is package.mask'd for testing.