Bugzilla Bug 112483

I tried to emerge warzone2100 and I didn't have mp3 in my USE flags. The
compilation aborted with "error: mad.h: No such file or directory".

Reproducible: Always
Steps to Reproduce:
1. emerge -C libmad
2. USE=-mp3 emerge warzone2100
Actual Results:  
[...]
audio.c:1293: warning: pointer targets in passing argument 2 of 

I tried to emerge warzone2100 and I didn't have mp3 in my USE flags. The
compilation aborted with "error: mad.h: No such file or directory".

Reproducible: Always
Steps to Reproduce:
1. emerge -C libmad
2. USE=-mp3 emerge warzone2100
Actual Results:  
[...]
audio.c:1293: warning: pointer targets in passing argument 2 of ‘resGetData’
differ in signedness
audio.c: In function ‘audio_GetTrackIDFromHash’:
audio.c:1324: warning: pointer targets in passing argument 1 of
‘resGetDataFromHash’ differ in signedness
if i686-pc-linux-gnu-gcc -DHAVE_CONFIG_H -I. -I. -I../..  -I../framework
-I../gamelib -I../.. -march=athlon-tbird -Os -pipe -I/usr/include/SDL
-D_REENTRANT -I/usr/X11R6/include/SDL  -march=athlon-tbird -Os -pipe
-I/usr/include/SDL -D_REENTRANT -Wall -DYY_STATIC -MT cdaudio.o -MD -MP -MF
".deps/cdaudio.Tpo" -c -o cdaudio.o cdaudio.c; \
then mv -f ".deps/cdaudio.Tpo" ".deps/cdaudio.Po"; else rm -f
".deps/cdaudio.Tpo"; exit 1; fi
cdaudio.c:10:17: error: mad.h: No such file or directory
make[3]: *** [cdaudio.o] Error 1
make[3]: Leaving directory
`/var/tmp/portage/warzone2100-0.2.2/work/warzone2100-0.2.2/lib/sound'
make[2]: *** [all-recursive] Error 1
make[2]: Leaving directory
`/var/tmp/portage/warzone2100-0.2.2/work/warzone2100-0.2.2/lib'
make[1]: *** [all-recursive] Error 1
make[1]: Leaving directory
`/var/tmp/portage/warzone2100-0.2.2/work/warzone2100-0.2.2'
make: *** [all] Error 2

!!! ERROR: games-strategy/warzone2100-0.2.2 failed.
!!! Function src_compile, Line 47, Exitcode 2
!!! emake failed
!!! If you need support, post the topmost build error, NOT this status message.

Expected Results:  
Install :)

cdaudio.c doesn't #include mad.h if WZ_NOMP3 is defined, but unfortunately, it's
defined in config.h which is included by frame.h which is included too late in
cdaudio.c. I'll attach a patch in a bit after making sure it works correctly.

Portage 2.0.53_rc7 (default-linux/x86/2005.1, gcc-4.0.2, glibc-2.3.6-r0,
2.6.14-mm2 i686)
=================================================================
System uname: 2.6.14-mm2 i686 AMD Duron(tm) Processor
Gentoo Base System version 1.12.0_pre10
dev-lang/python:     2.4.2
sys-apps/sandbox:    1.2.13
sys-devel/autoconf:  2.13, 2.59-r7
sys-devel/automake:  1.4_p6, 1.5, 1.6.3, 1.7.9-r1, 1.8.5-r3, 1.9.6-r1
sys-devel/binutils:  2.16.1
sys-devel/libtool:   1.5.20-r1
virtual/os-headers:  2.6.11-r2
ACCEPT_KEYWORDS="x86 ~x86"
AUTOCLEAN="yes"
CBUILD="i686-pc-linux-gnu"
CFLAGS="-march=athlon-tbird -Os -pipe"
CHOST="i686-pc-linux-gnu"
CONFIG_PROTECT="/etc /usr/kde/2/share/config /usr/kde/3/share/config
/usr/lib/X11/xkb /usr/share/config /var/qmail/control"
CONFIG_PROTECT_MASK="/etc/gconf /etc/terminfo /etc/env.d"
CXXFLAGS="-march=athlon-tbird -Os -pipe"
DISTDIR="/var/dist"
FEATURES="autoconfig cvs distlocks notitles sandbox sfperms sign strict"
GENTOO_MIRRORS="                http://ftp.easynet.nl/mirror/gentoo            
http://distfiles.gentoo.org   "
LANG="en_GB.UTF-8"
LINGUAS="en en_GB ga ja nl"
PKGDIR="/var/pkg"
PORTAGE_TMPDIR="/var/tmp"
PORTDIR="/var/cvs/gentoo-x86"
PORTDIR_OVERLAY="/etc/portage/overlay"
SYNC="rsync://rsync.gentoo.org/gentoo-portage"
USE="x86 3dnow 3dnowext X apm audiofile avi bidi bitmap-fonts bmp bzip2
cdparanoia cjk crypt cups dlloader dvdread emboss expat ftp gif gpgme gstreamer
gtk gtk2 idn imagemagick imlib ipv6 ithreads jpeg kde lcms libg++ libwww
linuxthreads-tls lynxkeymap mbox mikmod mmx mng motif mozdevelop mozsvg mpeg
ncurses nls nocxx nopie nossp nptl offensive ogg oggvorbis openal oss pdflib pic
png ppds qt quicktime readline reiser4 rtc sdl spell ssl tiff truetype
truetype-fonts type1-fonts udev unicode userlocales vorbis xml2 xv zlib linguas
linguas_en linguas_en_GB linguas_ga linguas_ja linguas_nl userland userland_GNU
kernel kernel_linux elibc elibc_glibc"
Unset:  ASFLAGS, CTARGET, LC_ALL, LDFLAGS, MAKEOPTS

Created an attachment (id=72863) [edit]
patch

With this, warzone installs and runs for me.

fixed in CVS.  Thanks for the bug report and patch.