First Last Prev Next    No search results available      Search page      Enter new bug
Bug#: 111364
Alias:
Product:
Component:
Status: RESOLVED
Resolution: FIXED
Assigned To: Mobile Herd <mobile@gentoo.org>
Hardware:
OS:
Version:
Priority:
Severity:
Reporter: Poggi Jérôme <gentoo.org@efflam.net>
Add CC:
CC:
Remove selected CCs
URL:
Summary:
Status Whiteboard:
Keywords:

Filename Description Type Creator Created Size Actions
wifiscanner-1.0.1.ebuild ebuild for WifiScanner-1.0.1 text/plain Poggi Jérôme 2005-11-03 08:26 0000 1.06 KB Details
Create a New Attachment (proposed patch, testcase, etc.) View All

Bug 111364 depends on: Show dependency tree
Show dependency graph
Bug 111364 blocks:
Votes: 0    Show votes for this bug    Vote for this bug

Additional Comments: (this is where you put emerge --info)







View Bug Activity   |   Format For Printing   |   XML   |   Clone This Bug


Description:   Opened: 2005-11-03 08:03 0000
please find attached an ebuild for the wifiscanner 1.0.1 hosted on sourceforge.
This version correct the collision with Ethereal Bug #88331

Reproducible: Always
Steps to Reproduce:

------- Comment #1 From Poggi Jérôme 2005-11-03 08:26:22 0000 -------
Created an attachment (id=72025) [edit]
ebuild for WifiScanner-1.0.1

------- Comment #2 From Priit Laes 2005-12-26 05:16:29 0000 -------
Looks good to me.

------- Comment #3 From Petteri Räty 2005-12-26 05:36:26 0000 -------
(In reply to comment #1)
> Created an attachment (id=72025) [edit]
> ebuild for WifiScanner-1.0.1
> 

A couple of comments to improve your ebuild writing skills:

DEPEND="${RDEPEND} sys-libs/zlib
zlib is part of system and as such not needed here
http://dev.gentoo.org/~plasmaroo/devmanual//general-concepts/dependencies/

This is also in the current ebuild because of which it is always best to be
aware that also ebuilds in the tree can have QA problems.

src_install () {

It is customary to have the functions in the order they are executed so
src_install comes after src_compile

        local config=""
        if ! use ethereal; then
                config="${config} --with-internal-wiretap --enable-wtap"
        else
                config="${config} --without-internal-wiretap --enable-wtap"
        fi

This is how I would do this:

        local config="--enable-wtap"
        if use ethereal; then
                config="${config} --without-internal-wiretap"
        else
                config="${config} --with-internal-wiretap"
        fi

This is not especially long so you can just put in on one line
        econf ${config} --enable-curses || die "econf failed"

Is there a reason that curses is not use flagged?

Thanks for the work so far.

------- Comment #4 From Petteri Räty 2005-12-26 05:38:24 0000 -------
Hmm. sorry, there is an even better way to do this:

config="${config} --with-internal-wiretap --enable-wtap"

http://dev.gentoo.org/~plasmaroo/devmanual//ebuild-writing/functions/src_compile/configure/

------- Comment #5 From Stefan Schweizer 2006-01-02 12:35:24 0000 -------
thanks, fixed

First Last Prev Next    No search results available      Search page      Enter new bug