Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 110892 - media-sound/audacious is likely to compile on x86
Summary: media-sound/audacious is likely to compile on x86
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: New packages (show other bugs)
Hardware: x86 Linux
: High normal (vote)
Assignee: Gentoo Developers for the x86 Architecture
URL: http://audacious.nenolod.net/Downloads
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2005-10-30 06:23 UTC by Tony Vroon (RETIRED)
Modified: 2005-10-30 13:57 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Tony Vroon (RETIRED) gentoo-dev 2005-10-30 06:23:23 UTC
Please consider media-sound/audacious for ~x86 keywording. Please test pure WAV
(no ADPCM compression supported), MP3, Ogg/Vorbis & FLAC playback. AAC is being
built but it will not work as of yet.
Comment 1 Petteri Räty (RETIRED) gentoo-dev 2005-10-30 12:56:39 UTC
Looked at the ebuild and a couple of comments:
    if ! useq mp3; then
        ewarn "MP3 support is now optional and you have not enabled it."
    fi

Should probably be use mp3?

I also don't like the fact that aac is built if it does not work. Why not just
make the code commented in the ebuild and enable it when it works? At least you
should give a note in pkg_postinst that aac is not working.
Comment 2 Tony Vroon (RETIRED) gentoo-dev 2005-10-30 13:20:00 UTC
betelgeuse, I challenge you to disable it. AAC builds but doesn't work properly,
if you tell the configure script to disable it, it pretends to do so but the
code gets built anyway.
My ebuilds have used useq for a long time, has that been deprecated?
Comment 3 Petteri Räty (RETIRED) gentoo-dev 2005-10-30 13:33:08 UTC
(In reply to comment #2)
> betelgeuse, I challenge you to disable it. AAC builds but doesn't work properly,
> if you tell the configure script to disable it, it pretends to do so but the
> code gets built anyway.
> My ebuilds have used useq for a long time, has that been deprecated?

Well if you can't force disable it, then you have have a broken use flag. If I
specify USE="-aac", the result should not have any aac support. You should file
a bug upstream if this is the case. 

See:
http://dev.gentoo.org/~plasmaroo/devmanual//function-reference/query-functions/
I don't think it is deprecated but I don't see any reason to supress the output
here. Of course at the moment use just calls useq but that could change in the
future.

betelgeuse@pena /usr/portage $ find -name "*.ebuild" | xargs grep -e "\buse\b" |
wc -l
23598
betelgeuse@pena /usr/portage $ find -name "*.ebuild" | xargs grep -e "\buseq\b"
| wc -l
935

Of course the use word is used in other things as the use function call, but the
point being that it is probably the more used of the two.
Comment 4 Petteri Räty (RETIRED) gentoo-dev 2005-10-30 13:57:16 UTC
Tested mp3, ogg, wav and flac playback and they all seem to work fine. Even the
Finnish translations seem to be there. I don't think the aac issues prevents
adding ~x86 so the actual issue of this bug is fixed. The aac thing does need to
be addressed before going stable of course.