Home | Docs | Forums | Lists | Bugs | Planet | Store | GMN | Get Gentoo!
View Bug Activity | Format For Printing | XML | Clone This Bug
Xpuyopuyo is a Tetris-like game in which the object is to match four or more blocks of the same color. Reproducible: Always Steps to Reproduce:
Created an attachment (id=71165) [edit] xpuyopuyo-0.9.8.ebuild
- remove # likewhoa - src_unpack() is superfluous
Created an attachment (id=71253) [edit] xpuyopuyo-0.9.8.ebuild [updated] updated to conform to ebuild standards..
What is with all of the USE flags? Are they all necessary? For example, we build shared libraries by default, so there's no need for the shared USE. The ebuild has gtk+-1.2 as a hard dependency and X as an optional one. This cannot be correct. You'll need to check the dependencies and fix that before this can be included. By the way, these ebuilds are pretty good, so keep up the good work.
Created an attachment (id=71360) [edit] xpuyopuyo-0.9.8.ebuild tookout some USE flags that were not needed.. look out tetris! xpuyopuyo rocks with AI and network play :)
(In reply to comment #4) > What is with all of the USE flags? Are they all necessary? > For example, we build shared libraries by default, so there's no need for the > shared USE. > The ebuild has gtk+-1.2 as a hard dependency and X as an optional one. This > cannot be correct. > > You'll need to check the dependencies and fix that before this can be included. > > By the way, these ebuilds are pretty good, so keep up the good work. I took X as an optional use flag and just appended --with-x but i did add 'gnome' use flag in replacement since it's an optional configure flag.. the 'aibreed' 'network' 'profiling' 'static' are the other USE flag that are optional since some are set to no by default.. enjoy the game it's pretty fun specially with network gaming. I will be adding more ebuilds as i would like to learn most of the eclass functions in portage.
Use make DESTDIR="${D}" install intead of egamesinstall. No need for the profiling support. needs to have a versioned archive file instead of -latest. read http://www.gentoo.org/proj/en/desktop/games/games-ebuild-howto.xml
Created an attachment (id=71370) [edit] xpuyopuyo-0.9.8.ebuild fixed src_uri link and setup 'make DESTDIR={D} install" insted of egamesinstall, plus added desktop entry and icon..
Ebuild is now in portage. Thanks