Bugzilla Bug 109793

smac: dynamic-link.h:57: elf_get_dynamic_info: Assertion `! "bad dynamic tag"'
failed.

BUG!  Exception triggered, cleaning up.
Sid Meier's Alpha Centauri 6.0a
Built with glibc-2.1 on x86
Please send the text of the failed assertion,
along with the contents of autosave to: support@lokigames.com
Unable to execute loki_qagent - exiting 

This is what I get, when I start smac[x], click Multiplayer, Internet Game.

http://www.gentoo.org/cgi-bin/viewcvs.cgi/eclass/eutils.eclass?r1=text&tr1=1.200&r2=text&tr2=1.201&diff_format=h
seems to be the change that broke it.

I think, there are actually 2 bugs:
- smac-6.0a.ebuild fails to pass /opt/smac as ${4} to make_games_wrapper
- make_wrapper changes LD_LIBRARY_PATH only if it is already set - why?

Reproducible: Always
Steps to Reproduce:

remerge smac and see if it's still a problem.  eutils is at 1.209 right now.

Did emerge --sync && emerge smac, no change, still the same error.

The wrapper script has change though, right?  So rediff with the wrapper script
that worked please.

This is the diff

$ diff smac.working smac.broken 
3c3,5
< export LD_LIBRARY_PATH="${LD_LIBRARY_PATH}:"
---
> if [ "${LD_LIBRARY_PATH+set}" = "set" ] && [ -n "" ] ; then
>       export LD_LIBRARY_PATH="${LD_LIBRARY_PATH}:"
> fi

Reverting that change fixes the issue.

logic should be this:
if [ -n "${libdir}" ] ; then
       if [ "\${LD_LIBRARY_PATH+set}" = "set" ] ; then
               export LD_LIBRARY_PATH="\${LD_LIBRARY_PATH}:${libdir}"
       else
               export LD_LIBRARY_PATH="${libdir}"
       fi
fi

fixed in cvs

Well, I still get that error message. Seems like the ebuild needs fixing, too
(don't know, why it worked before...)

Created an attachment (id=71062) [edit]
Patch to pass "${dir}" to games_make_wrapper as $libdir

Strange.  It works fine for me with the older ebuild.  I'll have to dig out my
media and try again with the newer eutils.eclass changes.

At any rate, I'll accept this one, since I think I'm the only one with the
actual game.

it probably 'worked' before because it would set LD_LIBRARY_PATH to ':' ... the
empty path in LD_LIBRARY_PATH implies $PWD which is the behavior you guys are
describing

Yeah, looks that way.

Btw: The ebuild for heroes3 looks like it has the same issue.

OK.  I *think* I got them all.  If you find that I missed something, feel free
to comment on it here and I'll get to it ASAP.