Bugzilla Bug 108464

Hi,

I have fixed some bugs in /etc/init.d/ifplugd (=sys-apps/ifplugd-0.28-r2)

Have a nice day

Christian


Reproducible: Always
Steps to Reproduce:
1.
2.
3.

Created an attachment (id=70133) [edit]
ifplugd.diff

The is_set function isn't broken, your patch appears to break it.....

SIGQUIT is signal 3 - SIGQUIT is easier to read, why the need to change to 3?

So why is this needed? Until a good argument can be given, I'll mark it as WONTFIX

First thing: is_set does not work here on amd64! If using == yes, then the
options --no-auto and --no-beep are not set (-ab).

Second: On both my machines (notebook and amd64) the init script does not
stop/restart, because portage tells me it needs a signal name or a signal
number. You used SIGQUIT and therefor it seems, portage is broken here. But
using a real number fixes this. So this is not really a bug in ifplugd but maybe
in start-stop-daemon (is this portage or baselayout??)

So if you do not change both things, the ifplugd stuff is broken on nearly all
~arch systems I (would) bet

I put some einfo in the is_set function to see the result

einfo "$1 $2 $3" and I got numbers 0/1. Not boolean words. So I changed it to -eq.

Hope you will test this. ;-)

Thanks anyway

Christian

Created an attachment (id=70223) [edit]
correct fix for ifplugd

OK, the is_set function does work - the error is assigning to an invalid iargs
variable.

The SIGQUIT option works for baselayout-1.12.0_pre* as we intercept
start-stop-daemon calls, but you're correct as 3 is needed for baselayout<1.12

Test this patch and see if it fixes your issues.

It works, although I don

It works, although I don´t understand the changes. But the patch is okay.

Thanks

Christian

Fixed in ifplugd-0.28-r3