First Last Prev Next    No search results available      Search page      Enter new bug
Bug#: 107571
Alias:
Product:
Component:
Status: RESOLVED
Resolution: FIXED
Assigned To: Gentoo KDE team <kde@gentoo.org>
Hardware:
OS:
Version:
Priority:
Severity:
Reporter: Gregorio Guidi (RETIRED) <greg_g@gentoo.org>
Add CC:
CC:
URL:
Summary:
Status Whiteboard:
Keywords:

Filename Description Type Creator Created Size Actions
kde-disable-visibility.patch kde-disable-visibility.patch patch Gregorio Guidi (RETIRED) 2005-09-29 01:47 0000 1.06 KB Details | Diff
Create a New Attachment (proposed patch, testcase, etc.) View All

Bug 107571 depends on: Show dependency tree
Show dependency graph
Bug 107571 blocks:
Votes: 0    Show votes for this bug    Vote for this bug

Additional Comments: (this is where you put emerge --info)







View Bug Activity   |   Format For Printing   |   XML   |   Clone This Bug

Description:   Opened: 2005-09-29 01:46 0000 
Hi, 
I would like to commit a patch to kde.eclass that replaces the current way we 
disable the gcc visibility support in the KDE build system. 
 
At the moment we remove the line with KDE_ENABLE_HIDDEN_VISIBILITY from 
configure.in.ins and regenerate configure. 
What the patch does is just setting 
'export kde_cv_prog_cxx_fvisibility_hidden=no' 
before running ./configure, which has the same effect (at least in my 
tests...) 
 
In this way we don't waste a lot of time by running autotools and we avoid the 
error-prone method of sedding configure.in.in (as shown by bug 107318). 
 
Can you give it a try and see if it's ok? I would like to commit the patch in 
a few days...

------- Comment #1 From Gregorio Guidi (RETIRED) 2005-09-29 01:47:42 0000 ------- 
Created an attachment (id=69468) [edit]
kde-disable-visibility.patch

------- Comment #2 From Marcus D. Hanwell 2005-10-01 08:39:53 0000 ------- 
That seems like a better way to do it to me too - the current way is causing 
configure failures for packages that worked fine before due to their buggy 
configure.in.in and stuff.

------- Comment #3 From Gregorio Guidi (RETIRED) 2005-10-03 01:03:06 0000 ------- 
No bad feedback... I committed the change now.
First Last Prev Next    No search results available      Search page      Enter new bug