Bugzilla Bug 107150

Since gtk2 flag was deprecated (Bug# 106560) the ebuild for xcdroast fails  
with the following error, even though I have gtk2 on my system:  
  
checking for GLIB - version >= 1.2.3... yes  
checking for gtk-config... no  
checking for GTK - version >= 1.2.3... no  
*** The gtk-config script installed by GTK could not be found  
*** If GTK was installed in PREFIX, make sure PREFIX/bin is in  
*** your path, or set the GTK_CONFIG environment variable to the  
*** full path to gtk-config.  
configure: error: Test for GTK failed. See the file 'INSTALL' for help.  
  
Output of qpkg -i -I gtk:  
  
# qpkg -i -I gtk  
x11-libs/gtk+-2.6.8 *  
        Gimp ToolKit + [ http://www.gtk.org/ ]  
app-text/gtkspell-2.0.4-r1 *  
        Spell checking widget for GTK2 [ http://gtkspell.sourceforge.net/ ]  
  
/etc/portage/package.use:  
...  
app-cdr/xcdroast                        gtk  
...  
 
I had to add the gtk flag in /etc/portage/package.use because otherwise 
xcdroast tried to bring in gdk-pixbuf, which, through a chain of dependencies, 
wanted to bring in gtk+-1 (which I try not to have on my system). 
 
As far as I know xcdroast should work fine with gtk2 (and it did as long as 
gtk2 flag was present). In fact the ebuild says: 
 
DEPEND="gtk? ( >=x11-libs/gtk+-2.0.3 ) 
        !gtk? ( >=media-libs/gdk-pixbuf-0.16.0 )" 
 
  

Reproducible: Always
Steps to Reproduce:
1. emerge --sync 
2. cat "app-cdr/xcdroast gtk" >> /etc/portage/package.use 
3. emerge -uN1Dtav world 
 
Actual Results:  
xcdroast ebuild fails with the above message. 

Expected Results:  
Reinstall xcdroast just fine 

# emerge --info 
Portage 2.0.51.22-r2 (default-linux/x86/2005.1, gcc-3.3.6, glibc-2.3.5-r1, 
2.6.12-gentoo-r10 i686) 
================================================================= 
System uname: 2.6.12-gentoo-r10 i686 AMD Athlon(tm) XP 2000+ 
Gentoo Base System version 1.6.13 
ccache version 2.3 [enabled] 
dev-lang/python:     2.3.5-r2 
sys-apps/sandbox:    1.2.12 
sys-devel/autoconf:  2.13, 2.59-r6 
sys-devel/automake:  1.4_p6, 1.5, 1.6.3, 1.7.9-r1, 1.8.5-r3, 1.9.6 
sys-devel/binutils:  2.15.92.0.2-r10 
sys-devel/libtool:   1.5.18-r1 
virtual/os-headers:  2.6.11-r2 
ACCEPT_KEYWORDS="x86" 
AUTOCLEAN="yes" 
CBUILD="i686-pc-linux-gnu" 
CFLAGS="-march=athlon-xp -O3 -pipe -fomit-frame-pointer" 
CHOST="i686-pc-linux-gnu" 
CONFIG_PROTECT="/etc /usr/kde/2/share/config /usr/kde/3.4/env /usr/kde/3.4/share/config /usr/kde/3.4/shutdown /usr/kde/3/share/config /usr/lib/X11/xkb /usr/share/config /usr/share/texmf/dvipdfm/config/ /usr/share/texmf/dvips/config/ /usr/share/texmf/tex/generic/config/ /usr/share/texmf/tex/platex/config/ /usr/share/texmf/xdvi/ /var/qmail/control" 
CONFIG_PROTECT_MASK="/etc/gconf /etc/terminfo /etc/env.d" 
CXXFLAGS="-march=athlon-xp -O3 -pipe -fomit-frame-pointer" 
DISTDIR="/usr/portage/distfiles" 
FEATURES="autoconfig ccache collision-protect distlocks sandbox sfperms strict 
userpriv usersandbox" 
GENTOO_MIRRORS="http://pandemonium.tiscali.de/pub/gentoo/ 
http://ftp.belnet.be/mirror/rsync.gentoo.org/gentoo/ 
http://ftp-stud.fht-esslingen.de/pub/Mirrors/gentoo/ 
http://mirror.switch.ch/mirror/gentoo/ 
http://ftp.snt.utwente.nl/pub/os/linux/gentoo" 
LC_ALL="it_IT.utf8" 
LINGUAS="it" 
MAKEOPTS="-j2" 
PKGDIR="/usr/portage/packages" 
PORTAGE_TMPDIR="/var/tmp" 
PORTDIR="/usr/portage" 
SYNC="rsync://rsync.europe.gentoo.org/gentoo-portage" 
USE="x86 3dnow X Xaw3d aalib acpi alsa arts avi berkdb bitmap-fonts bzip2 
bzlib caps cdparanoia cdr crypt cups curl dga dio divx4linux doc eds emboss 
encode exif fam fbcon ffmpeg fftw flac foomaticdb fortran ftp gcj gd gdbm gif 
glut gmp gphoto2 gpm gstreamer gtk2 hal iconv imagemagick java javascript jpeg 
kde kdeenablefinal kdexdeltas libg++ libwww lm_sensors mad maildir memlimit 
mikmod mime mmap mmx mng motif mozilla mp3 mpeg ncurses nls nptl offensive ogg 
oggvorbis openal opengl oss pam pcre pdflib perl png posix ppds python qt 
quicktime readline recode samba sdl sharedmem slang sndfile sockets sox speex 
spell sse ssl svg symlink sysfs sysvipc tcpd tetex threads tidy tiff truetype 
truetype-fonts type1-fonts unicode usb vcd vorbis win32codecs wmf xine xml2 xv 
xvid zlib linguas_it userland_GNU kernel_linux elibc_glibc" 
Unset:  ASFLAGS, CTARGET, LANG, LDFLAGS, PORTDIR_OVERLAY

It should work by changing $(use_enable gtk) to $(use_enable gtk gtk2), but the
proper fix is removing the gtk/2 flag altogether and always building the more
stable interface (whether that's the gtk1 or gtk2 interface is the maintainer's
decision); that was the whole point of bug #106560.

Please don't assign bugs unless you know where they go, reassigning.

Lars, it doesn't look like you've quite done the switch correctly. You need to
pick either the gtk1 or gtk2 interface to use as default. As such, xcdroast
shouldn't even need to use the "gtk" use flag. Right now it defaults to gtk+-1
and uses gtk+-2 if USE="gtk" which isn't the correct behaviour.

If you want the default to be gtk2, you'll need to change the use_enable line to
$(use_enable gtk gtk2).

Yes you are absolutly right. I was my mistake because i thought that this app
was enabled gtk2 by default.

Aargh! Please review dependencies! Despite being now gtk2 only, it requires  
gdk-pixbuf, which in turn requires gtk+-1.2. Is gdk-pixbuf really needed? It  
wasn't before all this gtk/gtk2 mess. 

Fixed... indeed gdk-pixbuf isn't needed for gtk2.