Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 106988 - Several cleanups for livecd-tools-1.0.25/autoconfig
Summary: Several cleanups for livecd-tools-1.0.25/autoconfig
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: New packages (show other bugs)
Hardware: All Linux
: High enhancement (vote)
Assignee: Gentoo LiveCD Package Maintainers
URL:
Whiteboard:
Keywords: InVCS
Depends on:
Blocks: 106990
  Show dependency tree
 
Reported: 2005-09-23 05:23 UTC by Joshua Kinard
Modified: 2005-11-11 08:58 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments
Patch to Cleanup minor quibbles in /etc/init.d/autoconfig (autoconfig-cleanup1.patch,1.87 KB, patch)
2005-09-23 05:24 UTC, Joshua Kinard
Details | Diff
Patch that re-writes chunks autoconfig in a cleaner style (autoconfig-cleanup2.patch,10.18 KB, patch)
2005-09-23 23:51 UTC, Joshua Kinard
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Joshua Kinard gentoo-dev 2005-09-23 05:23:22 UTC
Attached is a patch that makes some minor cleanups in 'autoconfig'.  Basic
points are:
   A) The removal of that rather ugly chunk of if-the-else statements at
      the top of the script and replacement with a case statement that is
      much smaller

   B) Type/spacing issue when printing out detected NICs; i.e.
      "* Network deviceeth0 detected"   changes to
      "* Network device eth0 detected"

   C) Add a newline after the "Skipping ALSA detection" message
      so that messages afterwards start where they should.
Comment 1 Joshua Kinard gentoo-dev 2005-09-23 05:24:14 UTC
Created attachment 69072 [details, diff]
Patch to Cleanup minor quibbles in /etc/init.d/autoconfig
Comment 2 Joshua Kinard gentoo-dev 2005-09-23 23:51:10 UTC
Created attachment 69147 [details, diff]
Patch that re-writes chunks autoconfig in a cleaner style

Most changes are code cosmetic to improve readability, others are functionality
(replacing ebegin's with appropriate einfo and ewarn's), etc..	May've altered
some of the color output when on a framebuffer console.
Comment 3 Chris Gianelloni (RETIRED) gentoo-dev 2005-10-12 10:15:37 UTC
I've added this to CVS, though slightly modifed...
Comment 4 Chris Gianelloni (RETIRED) gentoo-dev 2005-11-11 08:58:34 UTC
livecd-tools 1.0.26 has been added to portage