Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 104586 - Wish: Use "doc" USE flag in new openafs ebuilds to install documentation
Summary: Wish: Use "doc" USE flag in new openafs ebuilds to install documentation
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: High enhancement (vote)
Assignee: Stefaan De Roeck (RETIRED)
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2005-09-02 05:34 UTC by Dirk Heinrichs
Modified: 2005-10-30 06:23 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Dirk Heinrichs 2005-09-02 05:34:45 UTC
It would be nice if the new OpenAFS ebuilds would honor the "doc" USE flag 
to optionally install OpenAFS documentation. 

Reproducible: Always
Steps to Reproduce:
Comment 1 Stefaan De Roeck (RETIRED) gentoo-dev 2005-09-02 07:45:13 UTC
Preparing patch to install documentation together with openafs-1.4.0-rc2.  
I don't think 1.2.13 is worth the effort (especially if you look at how minimal
the change wrt the ibm docs is, see app-doc/afsdoc)
Comment 2 Stefaan De Roeck (RETIRED) gentoo-dev 2005-09-02 09:52:11 UTC
Fixed in openafs-1.4.0_rc2-r1
Comment 3 Dirk Heinrichs 2005-09-05 01:06:34 UTC
That was fast, but unfortunately, it doesn't work: 
 
gondolin ~ # equery uses openafs 
[ Searching for packages matching openafs... ] 
[ Colour Code : set unset ] 
[ Legend        : Left column  (U) - USE flags from 
make.conf                     ] 
[                  : Right column (I) - USE flags packages was installed with ] 
[ Found these USE variables for net-fs/openafs-1.4.0_rc2-r1 ] 
 U I 
 - - debug    : Tells configure and the makefiles to build for debugging. 
Effects vary across packages, but generally it will at least add -g to CFLAGS. 
Remember to set FEATURES=nostrip too 
 + + kerberos : Adds kerberos support 
 + + pam      : <unknown> 
 + + doc      : Adds extra documentation (API, Javadoc, etc) 
gondolin ~ # ll /usr/share/doc/openafs-1.4.0_rc2-r1/ 
total 12 
-rw-r--r--  1 root root 1081 Sep  5 10:00 ChangeLog.gz 
-rw-r--r--  1 root root 4566 Sep  5 10:00 README.gz 
 
Comment 4 Stefaan De Roeck (RETIRED) gentoo-dev 2005-09-05 01:36:52 UTC
Sorry, I think this bug was exposed by the revision bump to -r1, and I only
tested before the bump.

Could you try this patch and report on that?
Thanks,

Stefaan

--- openafs-1.4.0_rc3.ebuild.old        2005-09-05 09:50:10.000000000 +0200
+++ openafs-1.4.0_rc3.ebuild    2005-09-05 10:32:06.000000000 +0200
@@ -79,7 +79,7 @@

        # documentation package
        if use doc; then
-               cp -pPR doc/* ${D}/usr/share/doc/${P}
+               cp -pPR doc/* ${D}/usr/share/doc/${PF}
        fi

        # Gentoo related scripts
Comment 5 Dirk Heinrichs 2005-09-05 01:58:21 UTC
Looks good now. 
 
One little thing to add: When ready, the ebuild prints out (amongst others) 
this message: 
 
 * For browsing global Cells, please get CellServDB from 
 * /usr/share/doc/openafs-1.4.0_rc2-r1 and put in /etc/openafs.  Then start 
 * using /etc/init.d/afs right away. 
 
But there is no CellServDB in /usr/share/doc/openafs-1.4.0_rc2-r1 
Comment 6 Stefaan De Roeck (RETIRED) gentoo-dev 2005-09-05 02:15:54 UTC
True.  That is currently being done for you under certain circumstances (i.e.,
when there is no CellServdb yet, or when it looks like it was one previously
installed by gentoo).  So the message is certainly outdated. 

The plan is to replace the whole einfo message by: please check out the gentoo
openafs-documentation; after updating that documentation of course.  I have been
postponing this while openafs and the ebuilds were still a moving target, but
they seem to be stabilizing now.  
Comment 7 Stefaan De Roeck (RETIRED) gentoo-dev 2005-10-30 06:23:48 UTC
CellServDB is now installed again, plus patch for installation of official
OpenAFS-docs updated.  Fixed in openafs-1.4.0_rc8