First Last Prev Next    No search results available      Search page      Enter new bug
Bug#: 101059
Alias:
Product:
Component:
Status: RESOLVED
Resolution: FIXED
Assigned To: Python Gentoo Team <python@gentoo.org>
Hardware:
OS:
Version:
Priority:
Severity:
Reporter: int19h <me@int19h.org>
Add CC:
CC:
URL:
Summary:
Status Whiteboard:
Keywords:

Filename Description Type Creator Created Size Actions
pyvorbisfile.c.patch pyvorbisfile.c.patch patch Ian Leitch (RETIRED) 2005-09-05 12:58 0000 564 bytes Details | Diff
Create a New Attachment (proposed patch, testcase, etc.) View All

Bug 101059 depends on: Show dependency tree
Bug 101059 blocks: 78194
Votes: 0    Show votes for this bug    Vote for this bug

Additional Comments: (this is where you put emerge --info)


Not eligible to see or edit group visibility for this bug.






View Bug Activity   |   Format For Printing   |   XML   |   Clone This Bug

Description:   Opened: 2005-08-01 21:35 0000 
OVERVIEW:

Instances of VorbisFile class in pyvorbis-1.4 close the file descriptor twice in 
destructor. This makes any applications which use pyvorbis to play Vorbis files 
(e.g. media-sound/quodlibet) unusable.

STEPS TO REPRODUCE:

$ python -c "import ogg.vorbis; ogg.vorbis.VorbisFile('foo.ogg')"

ACTUAL RESULTS:

Crashes and displays a "double free or corruption" glibc error message.

EXPECTED RESULTS:

No output, successful termination.

DETAILS:

See pyvorbisfile.c, line 195. A file descriptor is fclose'd in destructor, after 
calling ov_clear. However, libvorbis docs specifically state that any file 
descriptor passed to ov_open should be closed by ov_clear, and that fclose 
should not be used on it.

PROPOSED SOLUTION:

Remove the offending fclose call before compiling.

------- Comment #1 From int19h 2005-09-01 01:37:32 0000 ------- 
Since pyvorbis-1.3 works fine as well, and 1.4 is broken badly, perhaps you 
could just as well hardmask 1.4.

Also see http://sacredchao.net/quodlibet/wiki/FAQ, second question under 
"General".

------- Comment #2 From Ian Leitch (RETIRED) 2005-09-05 12:58:07 0000 ------- 
Created an attachment (id=67693) [edit]
pyvorbisfile.c.patch

I came across this problem and created a patch in bug #78194 (before seeing
this bug). My diagnosis was exactly the same as yours.

Please test and apply.

------- Comment #3 From Ian Leitch (RETIRED) 2005-09-16 05:36:24 0000 ------- 
Can we get this into CVS, please?

------- Comment #4 From Ian Leitch (RETIRED) 2005-11-13 09:58:17 0000 ------- 
In CVS.

------- Comment #5 From Ian Leitch (RETIRED) 2005-11-13 16:26:20 0000 ------- 
fixed.
First Last Prev Next    No search results available      Search page      Enter new bug